Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977C9C11F65 for ; Wed, 30 Jun 2021 15:05:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF8FD61420 for ; Wed, 30 Jun 2021 15:05:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF8FD61420 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lybmn-0001pY-0V for qemu-devel@archiver.kernel.org; Wed, 30 Jun 2021 11:05:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lybjz-0008Km-HN for qemu-devel@nongnu.org; Wed, 30 Jun 2021 11:03:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lybjt-0002Q2-5H for qemu-devel@nongnu.org; Wed, 30 Jun 2021 11:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625065376; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QqP9LJFJT8d+jk9ExyxP5c6o6sQTP7oFdPC3MAszGKc=; b=GxriBRlllPWDVbdO3yPBFLx/sqJUXyoQUIHV3Z/z/7cG0i26IboQarP9Kz7FBxjBGxZaFx Yhmmx0l9+eYQToogNOGKdqM16sR8KjbPIt+JAXc3jDafja2LmmWSfpyALI55/T5RS2e2o9 S2IS7P06Y5QOz/6OOXhnvNU4PsHoW/4= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-hA1A1r-lP0-enfrposywNg-1; Wed, 30 Jun 2021 11:02:54 -0400 X-MC-Unique: hA1A1r-lP0-enfrposywNg-1 Received: by mail-pl1-f200.google.com with SMTP id t10-20020a170902b20ab029011b9ceafaafso1119559plr.11 for ; Wed, 30 Jun 2021 08:02:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language; bh=QqP9LJFJT8d+jk9ExyxP5c6o6sQTP7oFdPC3MAszGKc=; b=oEn9SZfdVCzKUdxcR0Cx7knDNcpgID7Ot2+MM2/rviKc0+aF/SBstm8RTClLzVA3Q6 GCvROF/21bMIpx95K3wCRm4CNYbATNsuoQlMWKaH9A7du3C167mkOGwxjooimDwZJkmL C8O+2k3PQAValkOqZ48eRknVStBZH7H6/dSgRyIjL0meORKLkrKAVVktaIZB6AheNwms B+BfZWYGfyK+hjdcaAJuiDdAIo4nc/C8i2oX1oQZEptk5+8v0X6igUqqTyiSNgI7E1vT jds+YYqTOulzD7qPlKIDaFzSvHXr7GNXurbNdAqHuLsVk/isy5qvuj8Mz4+z5kCjtSQc ObNg== X-Gm-Message-State: AOAM532AxuGRldUzPmu1YTFgn1Jxco5iJ8v7VF3J3xGBvFxd4Wpx1kBa +K3nGXTKHjxo1TG/QQ25kBfqcvJoand1+tIlQmK6jClVAR7wjvdamMwQLIYPmTRj1ajme3a7d1A votzOqHhngdS0EAU= X-Received: by 2002:aa7:8e19:0:b029:30c:3dbc:8d0f with SMTP id c25-20020aa78e190000b029030c3dbc8d0fmr17205941pfr.27.1625065373581; Wed, 30 Jun 2021 08:02:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMDUV/oltlhncVcaS48/t1oCmKVR/0kiITsXIcWLSSpwFi94J+anSFi+BNmrVY+fLbAgwn2A== X-Received: by 2002:aa7:8e19:0:b029:30c:3dbc:8d0f with SMTP id c25-20020aa78e190000b029030c3dbc8d0fmr17205885pfr.27.1625065373191; Wed, 30 Jun 2021 08:02:53 -0700 (PDT) Received: from wainer-laptop.localdomain ([179.105.223.44]) by smtp.gmail.com with ESMTPSA id h18sm23387423pgl.87.2021.06.30.08.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jun 2021 08:02:52 -0700 (PDT) Subject: Re: [PATCH v3 11/15] python: add 'make check-dev' invocation To: John Snow , Willian Rampazzo References: <20210629214323.1329806-1-jsnow@redhat.com> <20210629214323.1329806-12-jsnow@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <874dc387-8b59-57dc-4d3f-00eef857eccc@redhat.com> Date: Wed, 30 Jun 2021 12:02:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------16237AA36E79C0D0644B5EE8" Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.435, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wainersm@redhat.com Cc: Thomas Huth , Eduardo Habkost , qemu-devel , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------16237AA36E79C0D0644B5EE8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 6/30/21 11:58 AM, John Snow wrote: > > > On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo > wrote: > > On Tue, Jun 29, 2021 at 6:43 PM John Snow > wrote: > > > > This is a *third* way to run the Python tests. Unlike the first two > > (check-pipenv, check-tox), this version does not require any > specific > > interpreter version -- making it a lot easier to tell people to > run it > > as a quick smoketest prior to submission to GitLab CI. > > > > Summary: > > > >   Checked via GitLab CI: > >     - check-pipenv: tests our oldest python & dependencies > >     - check-tox: tests newest dependencies on all non-EOL python > versions > >   Executed only incidentally: > >     - check-dev: tests newest dependencies on whichever python > version > > > > ('make check' does not set up any environment at all, it just > runs the > > tests in your current environment. All four invocations perform the > > exact same tests, just in different execution environments.) > > > > Signed-off-by: John Snow > > > --- > >  python/Makefile | 35 +++++++++++++++++++++++++++++++++-- > >  1 file changed, 33 insertions(+), 2 deletions(-) > > > > Reviewed-by: Willian Rampazzo > > > > Thanks. I am squashing in a hotfix here to add .dev-venv to > .gitignore, too. Not worth an entire respin for that. > (Assuming that's gonna be A-OK with both of you.) Acked-by: Wainer dos Santos Moschetta --------------16237AA36E79C0D0644B5EE8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 6/30/21 11:58 AM, John Snow wrote:


On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo <wrampazz@redhat.com> wrote:
On Tue, Jun 29, 2021 at 6:43 PM John Snow <jsnow@redhat.com> wrote:
>
> This is a *third* way to run the Python tests. Unlike the first two
> (check-pipenv, check-tox), this version does not require any specific
> interpreter version -- making it a lot easier to tell people to run it
> as a quick smoketest prior to submission to GitLab CI.
>
> Summary:
>
>   Checked via GitLab CI:
>     - check-pipenv: tests our oldest python & dependencies
>     - check-tox: tests newest dependencies on all non-EOL python versions
>   Executed only incidentally:
>     - check-dev: tests newest dependencies on whichever python version
>
> ('make check' does not set up any environment at all, it just runs the
> tests in your current environment. All four invocations perform the
> exact same tests, just in different execution environments.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/Makefile | 35 +++++++++++++++++++++++++++++++++--
>  1 file changed, 33 insertions(+), 2 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>


Thanks. I am squashing in a hotfix here to add .dev-venv to .gitignore, too. Not worth an entire respin for that.
(Assuming that's gonna be A-OK with both of you.)

Acked-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

--------------16237AA36E79C0D0644B5EE8--