Date:   Sat, 10 Apr 2021 20:03:53 +0100
Message-ID: <874kgeezc6.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc:     catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com,
        0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de,
        linux-arm-kernel@lists.infradead.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok
In-Reply-To: <20210410181117.23967-1-eantoranz@gmail.com>
References: <20210410181117.23967-1-eantoranz@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi Edmundo,

On Sat, 10 Apr 2021 19:11:17 +0100,
Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:
> 
> The macro vdso_clocksource_ok is shadowing a function with the same
> name and so it actually makes no difference to have the macro defined
> or not.

No difference? Have you simply tried removing the macro and witness
the effect? If it made no difference, why have the macro at all then?

Also, run this, for example:

git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'

Are you going to "fix" these too?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.