Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2325CC47253 for ; Thu, 30 Apr 2020 18:43:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9D462070B for ; Thu, 30 Apr 2020 18:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ifym/Gvg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9D462070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUE9O-0002sN-0v for qemu-devel@archiver.kernel.org; Thu, 30 Apr 2020 14:43:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38020) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUDrB-0004n0-Jg for qemu-devel@nongnu.org; Thu, 30 Apr 2020 14:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUDpY-0003gJ-29 for qemu-devel@nongnu.org; Thu, 30 Apr 2020 14:24:20 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:27462 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jUDpX-0003fK-HQ for qemu-devel@nongnu.org; Thu, 30 Apr 2020 14:22:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588270957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AJvbLC2CDDW+2Wy/wjYtMdZbtgj8uY5u5+tlCI4RfXY=; b=Ifym/Gvg5wCOsWxrQZRA0Tzn0WcDRpBHW7Dn6voELnfidysKhcCoVNMQu+afyzohA7kTfG J8ZadhcBe0lAyJED1pwVX6VApmcA7Q9B9u5Q/vzlq4wssphOop4ea4KYceDcbfgBImdkxq 5MAYzI2pSkDKmwkZpbdMQBg6S5zgmLw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-C82eWpLxPI-4ar1Efztxyw-1; Thu, 30 Apr 2020 14:22:36 -0400 X-MC-Unique: C82eWpLxPI-4ar1Efztxyw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E35D219067E0; Thu, 30 Apr 2020 18:22:34 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A217579B6; Thu, 30 Apr 2020 18:22:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1A6E611358BC; Thu, 30 Apr 2020 20:22:23 +0200 (CEST) From: Markus Armbruster To: David Hildenbrand Subject: Re: [PATCH 08/17] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256 References: <20200428163419.4483-1-armbru@redhat.com> <20200428163419.4483-9-armbru@redhat.com> <7ed42e2f-e437-3d06-e46b-5416e4d2a6d3@redhat.com> Date: Thu, 30 Apr 2020 20:22:23 +0200 In-Reply-To: <7ed42e2f-e437-3d06-e46b-5416e4d2a6d3@redhat.com> (David Hildenbrand's message of "Tue, 28 Apr 2020 19:13:22 +0200") Message-ID: <874kt0bzq8.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/30 01:04:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, Cornelia Huck , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, pbonzini@redhat.com, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" David Hildenbrand writes: > On 28.04.20 18:34, Markus Armbruster wrote: >> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and >> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is >> "pcc-cmac-eaes-256". The former is obviously a pasto. >>=20 >> Impact: >>=20 >> * s390_feat_bitmap_to_ascii() misidentifies S390_FEAT_PCC_CMAC_AES_256 >> as "pcc-cmac-eaes-256". Affects QMP commands query-cpu-definitions, >> query-cpu-model-expansion, query-cpu-model-baseline, >> query-cpu-model-comparison, and the error message when >> s390_realize_cpu_model() fails in check_compatibility(). >>=20 >> * s390_realize_cpu_model() misidentifies it in check_consistency() >> warnings. >>=20 >> * s390_cpu_list() likewise. Affects -cpu help. >>=20 >> * s390_cpu_model_register_props() creates CPU property >> "pcc-cmac-eaes-256" twice. The second one fails, but the error is >> ignored (a later commit will change that). Results in a single >> property "pcc-cmac-eaes-256" with the description for >> S390_FEAT_PCC_CMAC_AES_256, and no property for >> S390_FEAT_PCC_CMAC_EAES_256. CPU properties are visible in CLI -cpu >> and -device, QMP & HMP device_add, QMP device-list-properties, and >> QOM introspection. >>=20 >> Fix by deleting the wayward 'e'. > > Very nice catch - thanks! :) > While this sounds very bad, it's luckily not that bad in practice > (currently). > > The feature (or rather, both features) is part of the feature group > "msa4". As long as we have all sub-features part of that group (which is > usually the case), we will always indicate "msa4" to the user, instead > of all the separate sub-features. So, expansion, baseline, comparison > will usually only work with "msa4". > > (in addition, current KVM is not capable of actually masking off these > sub-features, so it will still, always see the feature, even if not > explicitly specified via "-cpu X,pcc-cmac-aes-256=3Don) Would you like to propose an commit message improvements? > I think we should do stable backports. > > Reviewed-by: David Hildenbrand Thanks!