Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A96DC0651F for ; Thu, 4 Jul 2019 16:35:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C566218BC for ; Thu, 4 Jul 2019 16:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nq/cZkUZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C566218BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj4hv-0005Yy-Eh for qemu-devel@archiver.kernel.org; Thu, 04 Jul 2019 12:35:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48040) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj4hD-00051u-W1 for qemu-devel@nongnu.org; Thu, 04 Jul 2019 12:34:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hj4h8-0003Ne-Rv for qemu-devel@nongnu.org; Thu, 04 Jul 2019 12:34:54 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:35909) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hj4h7-0003Mw-Gg for qemu-devel@nongnu.org; Thu, 04 Jul 2019 12:34:50 -0400 Received: by mail-wm1-x344.google.com with SMTP id g67so552682wme.1 for ; Thu, 04 Jul 2019 09:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=lSJ0w0rG0qADFlxhJLHptbgSuQ2y6qnei3HvFpiG7Jg=; b=nq/cZkUZWPqUfZXcFoTagM/OFtzRa76kUXOxKD6fVyiiZvN2jFW8OjOMQR7KRC6Ktc 09o2k+mjjb462zI4ei2zO8VkBgHTY8pTP3REP5GCB5M5jM74ShZeYDh7Jadyb//ly4mw +MGH8PkmAEAuJZQdzX4Nbgu6/7oRqHZ5B6HLwMqps3skV3C9SDHCQVEFXGYfUKjIO8wN g/+mnrTA4Lbi+jRkVQIpu2U7YX2UvsOtMU8KRa+/MljD8kMdaq8CLxaJ0PkDtTqmSkjf 2FGaMGu3KKDziv/rHlzLWKjvW6ZfSvcHfLN761PMPkWTlBaZ4fWMXiKpD8uIxdT1RuGL cTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=lSJ0w0rG0qADFlxhJLHptbgSuQ2y6qnei3HvFpiG7Jg=; b=SbWpcBuvY74p0ZRh4L2UOdx8R/lef8lA3tAGgFXGOVUfTucHlgom0lqIAhBb0Aw1XC DIaGYPCfGsG9r14v3RBuilcJvRsyRoNIwAhBIf5wVJhYukbAycl9Q/RGAy5lmIY0tUJn VwI/bTxqxT5VzLs2n5Y2EBkr8XjBAYXE+J3BfhBEB3j8QFJqx4ETWCDHO0WJSfFcChpO U+0c+4tjpsoZYhXi1yc30p2bjuS654E43vL1uWq7GCTyn5MWFGUTuoTJxuND6XFCwIRT uTpnEPSuB5mdd3qoHVbbwnyl3ObmCMOtvu9/alnGIaVqkSfjXUGK1h6yBJEWkX44Xr1X HwjA== X-Gm-Message-State: APjAAAVw5TohiUqFaUPvIHclvthI5do1U/lsi1IYbzCYlGiNxNNCFNB2 Q/zwUYos+z/udHTtfFMU46OawA== X-Google-Smtp-Source: APXvYqwbb39TcEJ/HJvB9UQysXO0u5mH6X/pFTO9kLCWGLt03U+/rVorhR0CZjw8PFFnoAkrnH8qWw== X-Received: by 2002:a7b:c748:: with SMTP id w8mr275771wmk.36.1562258088317; Thu, 04 Jul 2019 09:34:48 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r2sm7471101wme.30.2019.07.04.09.34.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 09:34:47 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 624701FF87; Thu, 4 Jul 2019 17:34:47 +0100 (BST) References: <20190702210017.4275-1-vandersonmr2@gmail.com> <20190702210017.4275-4-vandersonmr2@gmail.com> User-agent: mu4e 1.3.2; emacs 26.1 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: qemu-devel@nongnu.org In-reply-to: <20190702210017.4275-4-vandersonmr2@gmail.com> Date: Thu, 04 Jul 2019 17:34:47 +0100 Message-ID: <874l41wyfs.fsf@zen.linaroharston> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: Re: [Qemu-devel] [PATCH v3 4/6] util/log: introduce dump of tbstats and -d hot_tbs:limit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Riku Voipio , vandersonmr , Laurent Vivier , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" vandersonmr writes: > add option to dump the N most hot TB blocks. > -d hot_tbs:N > and also add all tbstats dump functions. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/Makefile.objs | 1 + > accel/tcg/tb-stats.c | 293 +++++++++++++++++++++++++++++++++++ > include/exec/cpu-all.h | 43 +++++ > include/qemu/log-for-trace.h | 2 + > include/qemu/log.h | 1 + > linux-user/exit.c | 3 + > util/log.c | 35 ++++- > 7 files changed, 370 insertions(+), 8 deletions(-) > create mode 100644 accel/tcg/tb-stats.c > > diff --git a/accel/tcg/Makefile.objs b/accel/tcg/Makefile.objs > index d381a02f34..59d50d2dc5 100644 > --- a/accel/tcg/Makefile.objs > +++ b/accel/tcg/Makefile.objs > @@ -3,6 +3,7 @@ obj-$(CONFIG_SOFTMMU) +=3D cputlb.o > obj-y +=3D tcg-runtime.o tcg-runtime-gvec.o > obj-y +=3D cpu-exec.o cpu-exec-common.o translate-all.o > obj-y +=3D translator.o > +obj-y +=3D tb-stats.o > > obj-$(CONFIG_USER_ONLY) +=3D user-exec.o > obj-$(call lnot,$(CONFIG_SOFTMMU)) +=3D user-exec-stub.o > diff --git a/accel/tcg/tb-stats.c b/accel/tcg/tb-stats.c > new file mode 100644 > index 0000000000..922023f29d > --- /dev/null > +++ b/accel/tcg/tb-stats.c > @@ -0,0 +1,293 @@ > +#include "qemu/osdep.h" > +#include "qemu-common.h" > + > +/* XXX: I'm not sure what includes could be safely removed */ > +#define NO_CPU_IO_DEFS > +#include "cpu.h" > +#include "trace.h" > +#include "disas/disas.h" > +#include "exec/exec-all.h" > +#include "tcg.h" > +#if defined(CONFIG_USER_ONLY) > +#include "qemu.h" > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > +#include > +#if __FreeBSD_version >=3D 700104 > +#define HAVE_KINFO_GETVMMAP > +#define sigqueue sigqueue_freebsd /* avoid redefinition */ > +#include > +#include > +#define _KERNEL > +#include > +#undef _KERNEL > +#undef sigqueue > +#include > +#endif > +#endif > +#else > +#include "exec/ram_addr.h" > +#endif > + > +#include "qemu/qemu-print.h" > + > + > +/* only accessed in safe work */ > +static GList *last_search; > + > +static void collect_tb_stats(void *p, uint32_t hash, void *userp) > +{ > + last_search =3D g_list_prepend(last_search, p); > +} > + > +static void dump_tb_header(TBStatistics *tbs) > +{ > + qemu_log("TB%d: phys:0x"TB_PAGE_ADDR_FMT" virt:0x"TARGET_FMT_lx > + " flags:%#08x (trans:%lu uncached:%lu exec:%lu ints: g:%u o= p:%u h:%u h/g: %f)\n", > + tbs->display_id, > + tbs->phys_pc, tbs->pc, tbs->flags, > + tbs->translations.total, tbs->translations.uncached, > + tbs->executions.total, > + tbs->code.num_guest_inst, > + tbs->code.num_tcg_inst, > + tbs->code.num_host_inst, > + tbs->code.num_guest_inst ? > + ((float) tbs->code.num_host_inst / tbs->code.num_guest_i= nst) : > + 0); > +} > + > +static gint > +inverse_sort_tbs(gconstpointer p1, gconstpointer p2, gpointer psort_by) > +{ > + const TBStatistics *tbs1 =3D (TBStatistics *) p1; > + const TBStatistics *tbs2 =3D (TBStatistics *) p2; > + int sort_by =3D *((int *) psort_by); > + unsigned long c1 =3D 0; > + unsigned long c2 =3D 0; > + > + if (likely(sort_by =3D=3D SORT_BY_HOTNESS)) { > + c1 =3D tbs1->executions.total; > + c2 =3D tbs2->executions.total; > + } else if (likely(sort_by =3D=3D SORT_BY_HG)) { > + if (tbs1->code.num_guest_inst =3D=3D 0) { > + return -1; > + } > + if (tbs2->code.num_guest_inst =3D=3D 0) { > + return 1; > + } > + > + float a =3D (float) tbs1->code.num_host_inst / tbs1->code.num_gu= est_inst; > + float b =3D (float) tbs2->code.num_host_inst / tbs2->code.num_gu= est_inst; > + c1 =3D a <=3D b ? 0 : 1; > + c2 =3D a <=3D b ? 1 : 0; > + } > + > + > + return c1 < c2 ? 1 : c1 =3D=3D c2 ? 0 : -1; > +} > + > + > +static void do_dump_coverset_info(int percentage) > +{ > + uint64_t total_exec_count =3D 0; > + uint64_t covered_exec_count =3D 0; > + unsigned coverset_size =3D 0; > + int id =3D 1; > + GList *i; > + > + g_list_free(last_search); > + last_search =3D NULL; > + > + /* XXX: we could pass user data to collect_tb_stats to filter */ > + qht_iter(&tb_ctx.tb_stats, collect_tb_stats, NULL); > + > + last_search =3D g_list_sort_with_data(last_search, inverse_sort_tbs, > + SORT_BY_HOTNESS); > + > + /* Compute total execution count for all tbs */ > + for (i =3D last_search; i; i =3D i->next) { > + TBStatistics *tbs =3D (TBStatistics *) i->data; > + total_exec_count +=3D tbs->executions.total; > + } > + > + for (i =3D last_search; i; i =3D i->next) { > + TBStatistics *tbs =3D (TBStatistics *) i->data; > + covered_exec_count +=3D tbs->executions.total; > + tbs->display_id =3D id++; > + coverset_size++; > + dump_tb_header(tbs); > + > + /* Iterate and display tbs until reach the percentage count cove= r */ > + if (((double) covered_exec_count / total_exec_count) > > + ((double) percentage / 100)) { > + break; > + } > + } > + > + qemu_log("\n------------------------------\n"); > + qemu_log("# of TBs to reach %d%% of the total exec count: %u\t", > + percentage, coverset_size); > + qemu_log("Total exec count: %lu\n", total_exec_count); > + qemu_log("\n------------------------------\n"); > + > + /* free the unused bits */ > + i->next->prev =3D NULL; > + g_list_free(i->next); > + i->next =3D NULL; > +} > + > + > +static void do_dump_tbs_info(int count, int sort_by) > +{ > + int id =3D 1; > + GList *i; > + > + g_list_free(last_search); > + last_search =3D NULL; > + > + /* XXX: we could pass user data to collect_tb_stats to filter */ > + qht_iter(&tb_ctx.tb_stats, collect_tb_stats, NULL); > + > + last_search =3D g_list_sort_with_data(last_search, inverse_sort_tbs, > + &sort_by); > + > + for (i =3D last_search; i && count--; i =3D i->next) { > + TBStatistics *tbs =3D (TBStatistics *) i->data; > + tbs->display_id =3D id++; > + dump_tb_header(tbs); > + } > + > + /* free the unused bits */ > + if (i && i->next) { > + i->next->prev =3D NULL; > + } > + g_list_free(i->next); > + i->next =3D NULL; > +} > + > +static void > +do_dump_coverset_info_safe(CPUState *cpu, run_on_cpu_data percentage) > +{ > + qemu_log_to_monitor(true); > + do_dump_coverset_info(percentage.host_int); > + qemu_log_to_monitor(false); > +} > + > +struct tbs_dump_info { > + int count; > + int sort_by; > +}; > + > +static void do_dump_tbs_info_safe(CPUState *cpu, run_on_cpu_data tbdi) > +{ > + struct tbs_dump_info *info =3D tbdi.host_ptr; > + qemu_log_to_monitor(true); > + do_dump_tbs_info(info->count, info->sort_by); > + qemu_log_to_monitor(false); > + g_free(info); > +} > + > +/* > + * When we dump_tbs_info on a live system via the HMP we want to > + * ensure the system is quiessent before we start outputting stuff. > + * Otherwise we could pollute the output with other logging output. > + */ > +void dump_coverset_info(int percentage, bool use_monitor) > +{ > + if (use_monitor) { > + async_safe_run_on_cpu(first_cpu, do_dump_coverset_info_safe, > + RUN_ON_CPU_HOST_INT(percentage)); > + } else { > + do_dump_coverset_info(percentage); > + } > +} > + > +void dump_tbs_info(int count, int sort_by, bool use_monitor) > +{ > + if (use_monitor) { > + struct tbs_dump_info *tbdi =3D g_new(struct tbs_dump_info, 1); > + tbdi->count =3D count; > + tbdi->sort_by =3D sort_by; > + async_safe_run_on_cpu(first_cpu, do_dump_tbs_info_safe, > + RUN_ON_CPU_HOST_PTR(tbdi)); > + } else { > + do_dump_tbs_info(count, sort_by); > + } > +} > + > +static void do_tb_dump_with_statistics(TBStatistics *tbs, int log_flags) > +{ > + CPUState *cpu =3D current_cpu; > + uint32_t cflags =3D curr_cflags() | CF_NOCACHE; > + int old_log_flags =3D qemu_loglevel; > + TranslationBlock *tb =3D NULL; > + > + qemu_set_log(log_flags); > + > + qemu_log("\n------------------------------\n"); > + dump_tb_header(tbs); > + > + if (sigsetjmp(cpu->jmp_env, 0) =3D=3D 0) { > + mmap_lock(); > + tb =3D tb_gen_code(cpu, tbs->pc, tbs->cs_base, tbs->flags, cflag= s); > + tb_phys_invalidate(tb, -1); > + mmap_unlock(); > + } else { > + /* > + * The mmap_lock is dropped by tb_gen_code if it runs out of > + * memory. > + */ > + fprintf(stderr, "%s: dbg failed!\n", __func__); > + assert_no_pages_locked(); > + } > + > + qemu_set_log(old_log_flags); > + > + tcg_tb_remove(tb); > +} > + > +struct tb_dump_info { > + int id; > + int log_flags; > + bool use_monitor; > +}; > + > +static void do_dump_tb_info_safe(CPUState *cpu, run_on_cpu_data info) > +{ > + struct tb_dump_info *tbdi =3D (struct tb_dump_info *) info.host_ptr; > + GList *iter; > + > + if (!last_search) { > + qemu_printf("no search on record"); > + return; > + } > + qemu_log_to_monitor(tbdi->use_monitor); > + > + for (iter =3D last_search; iter; iter =3D g_list_next(iter)) { > + TBStatistics *tbs =3D iter->data; > + if (tbs->display_id =3D=3D tbdi->id) { > + do_tb_dump_with_statistics(tbs, tbdi->log_flags); > + } > + } > + qemu_log_to_monitor(false); > + g_free(tbdi); > +} > + > +/* XXX: only from monitor? */ > +void dump_tb_info(int id, int log_mask, bool use_monitor) > +{ > + struct tb_dump_info *tbdi =3D g_new(struct tb_dump_info, 1); > + > + tbdi->id =3D id; > + tbdi->log_flags =3D log_mask; > + tbdi->use_monitor =3D use_monitor; > + > + async_safe_run_on_cpu(first_cpu, do_dump_tb_info_safe, > + RUN_ON_CPU_HOST_PTR(tbdi)); > + > + /* tbdi free'd by do_dump_tb_info_safe */ > +} > + > +void clean_tbstats_info(void) > +{ > +/* TODO: remove all tb_stats */ > +} > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index 536ea58f81..c4bfad75d3 100644 > --- a/include/exec/cpu-all.h > +++ b/include/exec/cpu-all.h > @@ -365,6 +365,49 @@ void dump_exec_info(void); > void dump_opcount_info(void); > #endif /* !CONFIG_USER_ONLY */ Lets move these external functions along with inline helpers and the TBStatsistics structure into their own file (tb-stats.h). exec-allh and cpu-all.h end up as dumping grounds and this stuff is all self contained. > > +/** > + * dump_coverset_info: report the hottest blocks to cover n% of execution > + * > + * @percentage: cover set percentage > + * @use_monitor: redirect output to monitor > + * > + * Report the hottest blocks to either the log or monitor > + */ > +void dump_coverset_info(int percentage, bool use_monitor); > + > +#define SORT_BY_HOTNESS 0 > +#define SORT_BY_HG 1 Use an enum for these - they are internal anyway. > + > +/** > + * dump_tbs_info: report the hottest blocks > + * > + * @count: the limit of hotblocks > + * @sort_by: property in which the dump will be sorted > + * @use_monitor: redirect output to monitor > + * > + * Report the hottest blocks to either the log or monitor > + */ > +void dump_tbs_info(int count, int sort_by, bool use_monitor); > + > +/** > + * dump_tb_info: dump information about one TB > + * > + * @id: the display id of the block (from previous search) > + * @mask: the temporary logging mask > + * @Use_monitor: redirect output to monitor > + * > + * Re-run a translation of a block at addr for the purposes of debug out= put > + */ > +void dump_tb_info(int id, int log_mask, bool use_monitor); > + > +/** > + * clean_tbstats_info: remove all tb_stats information > + * > + */ > +void clean_tbstats_info(void); > + > + > + > int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, > uint8_t *buf, target_ulong len, int is_write); > > diff --git a/include/qemu/log-for-trace.h b/include/qemu/log-for-trace.h > index 2f0a5b080e..d65eb83037 100644 > --- a/include/qemu/log-for-trace.h > +++ b/include/qemu/log-for-trace.h > @@ -21,6 +21,8 @@ > /* Private global variable, don't use */ > extern int qemu_loglevel; > > +extern int32_t max_num_hot_tbs_to_dump; > + > #define LOG_TRACE (1 << 15) > > /* Returns true if a bit is set in the current loglevel mask */ > diff --git a/include/qemu/log.h b/include/qemu/log.h > index 2fca65dd01..240b71f66a 100644 > --- a/include/qemu/log.h > +++ b/include/qemu/log.h > @@ -114,6 +114,7 @@ typedef struct QEMULogItem { > extern const QEMULogItem qemu_log_items[]; > > void qemu_set_log(int log_flags); > +void qemu_log_to_monitor(bool enable); > void qemu_log_needs_buffers(void); > void qemu_set_log_filename(const char *filename, Error **errp); > void qemu_set_dfilter_ranges(const char *ranges, Error **errp); > diff --git a/linux-user/exit.c b/linux-user/exit.c > index bdda720553..295d3f4cad 100644 > --- a/linux-user/exit.c > +++ b/linux-user/exit.c > @@ -28,6 +28,9 @@ extern void __gcov_dump(void); > > void preexit_cleanup(CPUArchState *env, int code) > { > + if (qemu_loglevel_mask(CPU_LOG_HOT_TBS)) { > + dump_tbs_info(max_num_hot_tbs_to_dump, SORT_BY_HOTNESS, false); > + } > #ifdef TARGET_GPROF > _mcleanup(); > #endif > diff --git a/util/log.c b/util/log.c > index 1d1b33f7d9..c0f1e9980f 100644 > --- a/util/log.c > +++ b/util/log.c > @@ -19,6 +19,7 @@ > > #include "qemu/osdep.h" > #include "qemu/log.h" > +#include "qemu/qemu-print.h" > #include "qemu/range.h" > #include "qemu/error-report.h" > #include "qapi/error.h" > @@ -30,21 +31,26 @@ FILE *qemu_logfile; > int qemu_loglevel; > static int log_append =3D 0; > static GArray *debug_regions; > +int32_t max_num_hot_tbs_to_dump; > +static bool to_monitor; > > /* Return the number of characters emitted. */ > int qemu_log(const char *fmt, ...) > { > int ret =3D 0; > - if (qemu_logfile) { > - va_list ap; > - va_start(ap, fmt); > + va_list ap; > + va_start(ap, fmt); > + > + if (to_monitor) { > + ret =3D qemu_vprintf(fmt, ap); > + } else if (qemu_logfile) { > ret =3D vfprintf(qemu_logfile, fmt, ap); > - va_end(ap); > + } > + va_end(ap); > > - /* Don't pass back error results. */ > - if (ret < 0) { > - ret =3D 0; > - } > + /* Don't pass back error results. */ > + if (ret < 0) { > + ret =3D 0; > } > return ret; > } > @@ -99,6 +105,11 @@ void qemu_set_log(int log_flags) > } > } > > +void qemu_log_to_monitor(bool enable) > +{ > + to_monitor =3D enable; > +} > + > void qemu_log_needs_buffers(void) > { > log_uses_own_buffers =3D true; > @@ -273,6 +284,9 @@ const QEMULogItem qemu_log_items[] =3D { > { CPU_LOG_TB_NOCHAIN, "nochain", > "do not chain compiled TBs so that \"exec\" and \"cpu\" show\n" > "complete traces" }, > + { CPU_LOG_HOT_TBS, "hot_tbs(:limit)", > + "show TBs (until given a limit) ordered by their hotness.\n" > + "(if no limit is given, show all)" }, > { 0, NULL, NULL }, > }; > > @@ -294,6 +308,11 @@ int qemu_str_to_log_mask(const char *str) > trace_enable_events((*tmp) + 6); > mask |=3D LOG_TRACE; > #endif > + } else if (g_str_has_prefix(*tmp, "hot_tbs")) { > + if (g_str_has_prefix(*tmp, "hot_tbs:") && (*tmp)[8] !=3D '\0= ') { > + max_num_hot_tbs_to_dump =3D atoi((*tmp) + 8); > + } > + mask |=3D CPU_LOG_HOT_TBS; > } else { > for (item =3D qemu_log_items; item->mask !=3D 0; item++) { > if (g_str_equal(*tmp, item->name)) { -- Alex Benn=C3=A9e