Received: from eggs.gnu.org ([209.51.188.92]:59893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grPLk-0002Y0-5v for qemu-devel@nongnu.org; Wed, 06 Feb 2019 10:42:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grPLj-0002nb-6M for qemu-devel@nongnu.org; Wed, 06 Feb 2019 10:42:56 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:39653) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grPLi-0002lm-UK for qemu-devel@nongnu.org; Wed, 06 Feb 2019 10:42:55 -0500 Received: by mail-wr1-x441.google.com with SMTP id t27so8068565wra.6 for ; Wed, 06 Feb 2019 07:42:53 -0800 (PST) References: <20190206105339.32664-1-david@redhat.com> <87ef8lneja.fsf@zen.linaroharston> <2f4bfa41-09d6-5103-5c69-9bb8912f5c58@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <2f4bfa41-09d6-5103-5c69-9bb8912f5c58@redhat.com> Date: Wed, 06 Feb 2019 15:42:51 +0000 Message-ID: <874l9gord0.fsf@zen.linaroharston> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1] softfloat: Implement float128_to_uint32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, Richard Henderson , Peter Maydell , Aurelien Jarno David Hildenbrand writes: > On 06.02.19 16:12, Alex Benn=C3=A9e wrote: >> >> David Hildenbrand writes: >> >>> Handling it just like float128_to_uint32_round_to_zero, that hopefully >>> is free of bugs :) >>> >>> Documentation basically copied from float128_to_uint64 >> >> Queued to fpu/next, thanks. >> >> BTW to test: >> >> tests/fp: add wrapping for f128_to_ui32 >> >> Needed to test: softfloat: add float128_is_{normal,denormal} > > Thanks, was that supposed to be "softfloat: Implement > float128_to_uint32" ? Ahh yes... too liberal with my C&P ;-) Thanks! > >> >> Signed-off-by: Alex Benn=C3=A9e >> >> 2 files changed, 3 insertions(+), 1 deletion(-) >> tests/fp/fp-test.c | 3 ++- >> tests/fp/wrap.inc.c | 1 + >> >> modified tests/fp/fp-test.c >> @@ -622,7 +622,8 @@ static void do_testfloat(int op, int rmode, bool exa= ct) >> test_ab_extF80_z_bool(true_ab_extF80M_z_bool, subj_ab_extF80M_z= _bool); >> break; >> case F128_TO_UI32: >> - not_implemented(); >> + test_a_f128_z_ui32_rx(slow_f128M_to_ui32, qemu_f128M_to_ui32, r= mode, >> + exact); >> break; >> case F128_TO_UI64: >> test_a_f128_z_ui64_rx(slow_f128M_to_ui64, qemu_f128M_to_ui64, r= mode, >> modified tests/fp/wrap.inc.c >> @@ -367,6 +367,7 @@ WRAP_80_TO_INT_MINMAG(qemu_extF80M_to_i64_r_minMag, >> WRAP_128_TO_INT(qemu_f128M_to_i32, float128_to_int32, int_fast32_t) >> WRAP_128_TO_INT(qemu_f128M_to_i64, float128_to_int64, int_fast64_t) >> >> +WRAP_128_TO_INT(qemu_f128M_to_ui32, float128_to_uint32, uint_fast32_t) >> WRAP_128_TO_INT(qemu_f128M_to_ui64, float128_to_uint64, uint_fast64_t) >> #undef WRAP_128_TO_INT >> >> -- >> Alex Benn=C3=A9e >> -- Alex Benn=C3=A9e