From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH 1/1] qmi_wwan: add MTU default to qmap network interface Date: Fri, 04 Jan 2019 14:24:23 +0100 Message-ID: <874laozhbs.fsf@miraculix.mork.no> References: <1546604770-31149-1-git-send-email-dnlplm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org To: Daniele Palmas Return-path: Received: from canardo.mork.no ([148.122.252.1]:40453 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726737AbfADNYb (ORCPT ); Fri, 4 Jan 2019 08:24:31 -0500 In-Reply-To: <1546604770-31149-1-git-send-email-dnlplm@gmail.com> (Daniele Palmas's message of "Fri, 4 Jan 2019 13:26:10 +0100") Sender: netdev-owner@vger.kernel.org List-ID: Daniele Palmas writes: > This patch adds MTU default value to qmap network interface in > order to avoid "RTNETLINK answers: No buffer space available" > error when setting an ipv6 address. > > Signed-off-by: Daniele Palmas > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 774e1ff..735ad83 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -123,6 +123,7 @@ static void qmimux_setup(struct net_device *dev) > dev->addr_len =3D 0; > dev->flags =3D IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST; > dev->netdev_ops =3D &qmimux_netdev_ops; > + dev->mtu =3D 1500; > dev->needs_free_netdev =3D true; > } Setting some value makes sense, but hard coding 1500 feels wrong. Should this relate to the real device mtu somehow? Do we need a ndo_change_mtu to enforce this relationship? Should qmimux_rx_fixup() respect the qmap device mtu? I'm fine with this patch as a first step and immediate fix, so Acked-by: Bj=C3=B8rn Mork