From: Eric Anholt Subject: Re: [PATCH 0/4] Reduce intel_display.c Date: Wed, 09 Apr 2014 14:49:33 -0700 Message-ID: <874n22tbpu.fsf@eliezer.anholt.net> References: <1397079873-18257-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1255347574==" Return-path: In-Reply-To: <1397079873-18257-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============1255347574== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Paulo Zanoni writes: > From: Paulo Zanoni > > Hi > > We always talk about how intel_display.c is a giant file and how we would like > to reduce it, so this is my attempt. Currently the file has 12090 lines, and > after my patch series it has 8850 lines. > > I don't know if right now is the appropriate time to merge patches like this. I > don't remember seeing too many patches on the list touching cursor/fdi/eld/pll > functions, but I know there is never an appropriate time for huge changes. > > Also, this change will obviously make the lives of people who backport our > patches more complicated. So if we don't want this series at all, feel free to > NACK it. > > I also didn't really know what kind of changes I needed to do to the file > headers, so I just copied the header from intel_display.c, kept Eric's name and > added a "2014" to Intel's copyright. I am not a lawyer and this may be not the > best thing to do, so please tell me the correct approach here :) > > There are also some things that we might want to migrate from intel_ddi.c to > intel_pll.c, but I'll leave this to another patch. > > Also, feel free to propose better ways to split intel_display.c. FWIW, I think "Authors" lines in headers are silly, now that we're using git. I'd be happy to see mine dropped. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJTRcBtAAoJELXWKTbR/J7or5oQAK7iU2J9ZGkmUUJSbrcGIwMu GRWq/eD0EWc2tmNSaD5i23CbFtON75g5agsMcW0W9G+vsf+dNk51hbJwB8yFyKD/ Z358ondI+JXqtse7r4YYiFhXbUM7XOk7QnfKeX07s8HKL4dNhBtK/hoxXZN8VqBy gceSDI1/DO+J3mP5bB69mOxPy5wPmDvUXyboPiEmRHhumMlgRy3ugOnSeVqwdBFJ JakkcSn23cn+aTbnna9MD3bpCdbRplT46lc2SCBu826CtSxtn+AmQvfi+Y+43wG7 eClEuX9x1wC4kR1TmfH9vFYyNH9gCkizRgH3x/cDX1aH62nSPdCjgP3HbpkEDlik 0qXfDyS2Kg+Q7TW/yGAsnaX6byWdc5bHS/eiKNv6qEQaLjJcLVTvOexOr4ABTT4d Bh2ret5KEHH+CB16ok1oQTSXAwNxeDthquyFfmj5FMoCLLYColzh43LESTKyoVGr S/G90+uZ1a/W93f9drARlfpY0hF0Md0AXHy7h5MtmVrom67+5s0zlR/wjsdIcoQl urNiFZk5vOINxz4QaaEgJfFQ6e1EqNFXi4IHRdevTsTgg+drhv42IxTxV8FwqhNQ ENqkbyFp0aFsTBlyhupA0ckBBDZcMpKEn9TyaZcuYCXWDn/7WsKb4GXtkLzLzLOW 0Jr7ExuRuCMXRRZTn5jW =jMQI -----END PGP SIGNATURE----- --=-=-=-- --===============1255347574== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1255347574==--