Received: from eggs.gnu.org ([2001:4830:134:3::10]:59757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB3yR-0004Ar-AL for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:01:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB3yM-0004Sg-I3 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:01:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB3yM-0004SZ-8d for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:01:06 -0500 From: Markus Armbruster References: <1391589562-9010-1-git-send-email-armbru@redhat.com> <52F1FC8C.8090705@suse.de> <871tzhd9wl.fsf@blackfin.pond.sub.org> Date: Wed, 05 Feb 2014 16:00:59 +0100 In-Reply-To: (Peter Maydell's message of "Wed, 5 Feb 2014 14:28:31 +0000") Message-ID: <874n4d4n9w.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Peter Crosthwaite , Andreas =?utf-8?Q?F=C3=A4rber?= , QEMU Developers Peter Maydell writes: > On 5 February 2014 13:00, Peter Maydell wrote: >> On 5 February 2014 12:24, Markus Armbruster wrote: >>> As to why it's complicated for Peter to fix, here's what Peter wrote: >>> "That series got very big on me with complications. I think near term >>> we just proceed with the revert. Sorry for the delay." I have no >>> reason to second-guess him. >>> >>> Promptly reverting patches that cause regressions when a fix isn't ready >>> is standard operating procedure. We can delay a revert a reasonable >>> amount of time to deliberate what to do, and perhaps find a fix. We did >>> that, and then some: four weeks. We should revert, and try again. >>> Neither harm nor shame in that. >> >> I agree in general here, which is why I'm going to apply this patch. > > Following conversation on IRC and Andreas' recent patch: > given that the current state of affairs (ie 'info qtest crashes') has been > in master for six months, there doesn't seem to be a critically urgent > need to act immediately, so I'm going to give it a few days to check > that we have a consensus on the best way to deal with this. Waiting a few more days for a fix is fine with me.