From: OGAWA Hirofumi Subject: Re: [PATCH 1/5] fat: add i_disksize to represent uninitialized size Date: Wed, 30 Oct 2013 10:23:29 +0900 Message-ID: <874n7zy2jy.fsf@devron.myhome.or.jp> References: <1381329627-11837-1-git-send-email-linkinjeon@gmail.com> <87zjpuygtd.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, a.sahrawat@samsung.com, Namjae Jeon To: Namjae Jeon Return-path: In-Reply-To: (Namjae Jeon's message of "Wed, 30 Oct 2013 08:01:07 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: >>> diff --git a/fs/fat/cache.c b/fs/fat/cache.c >>> index 91ad9e1..37572c2 100644 >>> --- a/fs/fat/cache.c >>> +++ b/fs/fat/cache.c >>> @@ -329,10 +329,10 @@ int fat_bmap(struct inode *inode, sector_t sector, >>> sector_t *phys, >>> return 0; >>> >>> /* >>> - * ->mmu_private can access on only allocation path. >>> + * ->i_disksize can access on only allocation path. >>> * (caller must hold ->i_mutex) >>> */ >>> - last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1)) >>> + last_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1)) >>> >> blocksize_bits; >>> if (sector >= last_block) >>> return 0; >> >> Hm, bmap() ioctl returns between ->mmu_private and i_disksize? I'm not >> checking other FSes what does... > I added this code after checking such behaviour from ext4. OK. I will check with it. BTW, comment should say the both (i.e. ->mmu_private and ->i_disksize must under ->i_mutex). -- OGAWA Hirofumi