From: khilman@deeprootsystems.com (Kevin Hilman) Date: Fri, 24 Sep 2010 07:58:09 -0700 Subject: [PATCH 1/2] OMAP: features: export symbol omap3_features In-Reply-To: <1285299665-21639-1-git-send-email-omar.ramirez@ti.com> (Omar Ramirez Luna's message of "Thu, 23 Sep 2010 22:41:04 -0500") References: <1285299665-21639-1-git-send-email-omar.ramirez@ti.com> Message-ID: <874odfkx32.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Omar Ramirez Luna writes: > From: Kevin Hilman Minor nit, can you make the subject something like: OMAP: features: make feature checks available to modules Thanks, Kevin > Since omap3_features is a global variable, only code > built-in the kernel can make use of it and thus use > omap_has ##feat functions; exporting this as a kernel > symbol makes modules able to use feature detection > framework too. > > Thread: http://marc.info/?l=linux-omap&m=128528822902211&w=2 > > Signed-off-by: Kevin Hilman > Signed-off-by: Omar Ramirez Luna > CC: Tony Lindgren > CC: Russell King > CC: Nishanth Menon > CC: Paul Walmsley > CC: Sanjeev Premi > CC: linux-omap at vger.kernel.org > CC: linux-arm-kernel at lists.infradead.org > --- > arch/arm/mach-omap2/id.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > index 9a879f9..a8c6d19 100644 > --- a/arch/arm/mach-omap2/id.c > +++ b/arch/arm/mach-omap2/id.c > @@ -31,6 +31,7 @@ static struct omap_chip_id omap_chip; > static unsigned int omap_revision; > > u32 omap3_features; > +EXPORT_SYMBOL(omap3_features); > > unsigned int omap_rev(void) > {