From: Eric Anholt Subject: Re: [PATCH] agpgart: Reprobe VGA devices when a new GART device is added Date: Mon, 01 Mar 2010 08:19:02 -0800 Message-ID: <874ol0c8w9.fsf@pollan.anholt.net> References: <1267327851.2282.8.camel@localhost> <21d7e9971003010033t1ec38beem5c79d18e79ac406c@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4746749069459332812==" Return-path: In-Reply-To: <21d7e9971003010033t1ec38beem5c79d18e79ac406c@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Dave Airlie , Ben Hutchings Cc: David Airlie , linux-pci@vger.kernel.org, dri-devel@lists.sourceforge.net, Greg Kroah-Hartman List-Id: dri-devel@lists.freedesktop.org --===============4746749069459332812== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 1 Mar 2010 18:33:14 +1000, Dave Airlie wrote: > On Sun, Feb 28, 2010 at 1:30 PM, Ben Hutchings wrot= e: > > This addresses . > > > > DRM drivers may fail to probe their devices when the associated AGP > > GART does not yet have a driver, so we reprobe unbound VGA devices > > when a GART device is added. > > > > Signed-off-by: Ben Hutchings > > --- > > This is intended to address the dependency problem highlighted in the > > above bug report. =C2=A0That specific bug can be fixed by adding a modu= le > > dependency from i915 to intel_agp, but in general there is no fixed > > relationship betweem DRM and GART drivers. > > > > There is a narrow race between the check for a current driver binding > > and the call to device_reprobe(). =C2=A0This could be closed by adding a > > variant on device_attach() and device_reprobe() that is a no-op for > > bound devices. > > >=20 > This isn't useful, generally there is no AGP binding, and most drivers > if they can't find an AGP backend will still run fine without it. i.e. ra= deon, > mga etc. >=20 > Intel is a special case and I think we've already merged an explicit > depend. >=20 > Just build agp drivers into the kernel, I'm tempted to make them all > non-modular. That seems easier. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkuL6PcACgkQHUdvYGzw6veFugCgiFnOOKJIkFh8Z7ovuEjs5XqP gSgAniC61mD7obvyf7L6E5sxRdQaJpPQ =QbT8 -----END PGP SIGNATURE----- --=-=-=-- --===============4746749069459332812== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --===============4746749069459332812== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel --===============4746749069459332812==--