Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LaAKQ-0000dA-3c for qemu-devel@nongnu.org; Thu, 19 Feb 2009 09:56:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LaAKO-0000cM-GG for qemu-devel@nongnu.org; Thu, 19 Feb 2009 09:56:41 -0500 Received: from [199.232.76.173] (port=40262 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LaAKO-0000cF-9i for qemu-devel@nongnu.org; Thu, 19 Feb 2009 09:56:40 -0500 Received: from mx2.redhat.com ([66.187.237.31]:50376) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LaAKN-0003Im-Oo for qemu-devel@nongnu.org; Thu, 19 Feb 2009 09:56:40 -0500 Subject: Re: [Qemu-devel] Machine description as data prototype, take 3 References: <87iqnh6kyv.fsf@pike.pond.sub.org> <871vtuafdr.fsf@pike.pond.sub.org> <200902191353.47491.paul@codesourcery.com> From: Markus Armbruster Date: Thu, 19 Feb 2009 15:55:35 +0100 In-Reply-To: <200902191353.47491.paul@codesourcery.com> (Paul Brook's message of "Thu\, 19 Feb 2009 13\:53\:47 +0000") Message-ID: <874oyq5vdk.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Paul Brook writes: > On Thursday 19 February 2009, Markus Armbruster wrote: >> Third iteration of the prototype. >> >> What about an early merge? If your answer to that is "yes, but", what >> exactly do you want changed? > > I dislike that you've got everything lumped together. In its current form it's > unclear that it's actually an improvement from what we currently have. There > still seems to be an awful lot of code that's extremely PC specific, and I > can't tell whether/which interfaces achieve separation from the legacy > hardcoded PC nastyness and generic machine descriptions. I think I got the PC nastiness encapsulated in driver methods. I can put them into a separate file if you think that would help. > I'm also worried that we have both user config (image files, vlans, etc) and > machine description (devices instantiation, etc) described in the same place. > I still believe these should be separate tasks, with clear boundaries between > the two. Actually, we don't. The machine configuration tree does not contain any host configuration (if it does, it's an oversight I'd be happy to fix). That is all in struct dt_host, a completely separate data structure. The two data structures join in two places: 1. dt_customize_config(), which bridges the gap between our current configuration system and the new configuration data structure. Since the former has machine and host configuration mixed up, dealing with the two together there is unavoidable. But keeping them separate from there on paves the way for keeping them separate from the start some day. 2. The driver config methods, which necessarily use both the machine and the host configuration.