From: Markus Armbruster Subject: Re: Missing checks for xc_map_foreign_range() failure Date: Fri, 31 Aug 2007 17:03:03 +0200 Message-ID: <874pifrbko.fsf@pike.pond.sub.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Keir Fraser's message of "Fri\, 31 Aug 2007 15\:11\:33 +0100") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir Fraser writes: > On 31/8/07 15:06, "Markus Armbruster" wrote: > >> Other, more naive uses would profit from a less awkward convenience >> function that either succeeds completely or fails completely. As far >> as I can see, these uses all neglect to check for the second failure >> mode so far. Potential crash bugs. > > Yes, that makes sense. Are you proposing to make a patch? Happy to do that :)