Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69078C369AB for ; Fri, 18 Apr 2025 20:55:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05C6110E2CE; Fri, 18 Apr 2025 20:55:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jr7zQFvl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 678DF10E2CE for ; Fri, 18 Apr 2025 20:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745009730; x=1776545730; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=pSrCpbsVspw+hSPK863wHN6Uy5Q/feJwYTgrCWWLvwQ=; b=jr7zQFvlQjk5S6FOL3mHPqzXr7kauOHoxm4PuuFnYBIywqhAE3rg38wX q5+3+y58cS+4J2vvGHnaAA3NS34AKrN/uiK3sGAy5xk0VcOx6w3kvWyoa lNS1zwheABCjKW6BvKbm3GdjBWHmw9NQvH3Uy74kKwz1TyCyuchC0CGLB 7v4qVtO8XdcdNUPFlwV/tQjkEpZww3zuQjj4m/X5zlFvuM7XdgNntXZU1 XFw24qd2ovK6V9u3OpK3+sS0ySHLkrST4H4E1GopoiO6HltOAq3sCPID8 x8e47lJcMJNVpkaTrrq/lOIHsnhUSCyqaJvYUjGkYIt4BK9Dmv4KEKT60 Q==; X-CSE-ConnectionGUID: GfAGUqoKSJGBc1CuaTYTzQ== X-CSE-MsgGUID: XpMZOPQ3TuiEdQscGUG6hQ== X-IronPort-AV: E=McAfee;i="6700,10204,11407"; a="46766554" X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="46766554" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2025 13:55:30 -0700 X-CSE-ConnectionGUID: qtQd6RKcTA+YASToquKbSg== X-CSE-MsgGUID: D6s2p6F2TUuvvM96Mo+gZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="131185698" Received: from smuhamma-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.96.160]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2025 13:55:30 -0700 Date: Fri, 18 Apr 2025 13:55:29 -0700 Message-ID: <875xj1gpfi.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: , , , Subject: Re: [PATCH v2] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests In-Reply-To: <20250418205211.346135-1-jonathan.cavitt@intel.com> References: <20250418205211.346135-1-jonathan.cavitt@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 18 Apr 2025 13:52:11 -0700, Jonathan Cavitt wrote: > > The guard was a holdover from i915 that is not relevant to Xe because > the buffer contents are preserved during an overflow. Remove the check. > > v2: Keep check for non-zero-reason test (Ashutosh) Reviewed-by: Ashutosh Dixit > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4541 > Suggested-by: Umesh Nerlige Ramappa > Suggested-by: Ashutosh Dixit > Signed-off-by: Jonathan Cavitt > --- > tests/intel/xe_oa.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 1fc8bfaafe..9db3d850c4 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2503,7 +2503,8 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b > while (total_len < buf_size && > ((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 || > (len == -1 && (errno == EINTR || errno == EIO)))) { > - if (errno == EIO) { > + /* Assert only for default OA buffer size */ > + if (errno == EIO && !oa_buffer_size) { > oa_status = get_stream_status(stream_fd); > igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW)); > } > -- > 2.43.0 >