Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D06D62C9C for ; Wed, 14 Jun 2023 15:15:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37623C433C9; Wed, 14 Jun 2023 15:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686755735; bh=IYlo4kFJO2TVbRcxmRqgX52nQUD+JoUM4Xtdb77hYmo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=L8/y2njeA9dvpmBLDS9b9VOFgU7bn/6Axd3gCwGdy5yLR9y2TYpTtK5sQOQ8kSSRS 3H+GT2aah72MhN7h0rby9iSLNoJa+QoW5WquxOJBh3bDbqieaEQFyVWttfVypNXAoD E4yHAzZnziz/TpDvEUQdU22jT6S3EBYJ1Dhj5qhI1kq+I0pwIsf39kOnOrMygtN9Jv pwSdfpNe43i8pavv/T5Ol0odDnE6xBW0s6vX/mMy6sbAOkrA9iocie8/zty1E5JlfF XYEHdBWtm3z4qKiolcKU/fEMYGs9F/mi74EM079kBrQJtYIYfR+dTBMr2KQ559SGXu rRGOJuArVX5yw== From: Kalle Valo To: Azeem Shaikh Cc: linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Johannes Berg Subject: Re: [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy() References: <20230614134956.2109252-1-azeemshaikh38@gmail.com> <874jnaf7fv.fsf@kernel.org> Date: Wed, 14 Jun 2023 18:15:31 +0300 In-Reply-To: (Azeem Shaikh's message of "Wed, 14 Jun 2023 10:55:13 -0400") Message-ID: <875y7qcbxo.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Azeem Shaikh writes: > On Wed, Jun 14, 2023 at 10:24=E2=80=AFAM Kalle Valo wr= ote: > >> >> Azeem Shaikh writes: >> >> > strlcpy() reads the entire source buffer first. >> > This read may exceed the destination size limit. >> > This is both inefficient and can lead to linear read >> > overflows if a source string is not NUL-terminated [1]. >> > In an effort to remove strlcpy() completely [2], replace >> > strlcpy() here with strscpy(). >> > >> > Direct replacement is safe here since WIPHY_ASSIGN is only used by >> > TRACE macros and the return values are ignored. >> > >> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#str= lcpy >> > [2] https://github.com/KSPP/linux/issues/89 >> > >> > Signed-off-by: Azeem Shaikh >> > --- >> > v1: https://lore.kernel.org/all/20230612232301.2572316-1-azeemshaikh38= @gmail.com/ >> > v2: https://lore.kernel.org/all/20230614134552.2108471-1-azeemshaikh38= @gmail.com/ >> >> In the change log (after the "---" line) you should also describe what >> changes you made, more info in the wiki below. In this case it's clear >> as the patch is simple but please keep this in mind for future patches. >> >> No need to resend because of this. >> > > Thanks Kalle. I did have the below line in my changelog. For future > patches, do you mean that changelog descriptions need to be more > specific than this? For example - updated title from "x" -> "y"? > >> Changes from v1 and v2 - updated patch title. Ah, I missed that because the format was not what we usually use. I recommend something like this: v3: * add bar v2: * https:// * fix foo v1: * https:// --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes