Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF9AC433ED for ; Fri, 23 Apr 2021 11:17:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84E09601FC for ; Fri, 23 Apr 2021 11:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84E09601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtoQ-0002B7-FX for qemu-devel@archiver.kernel.org; Fri, 23 Apr 2021 07:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtms-0000Qd-Ue for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:15:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtmr-0005JO-BC for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:15:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619176550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zz8n/8/z4bmvu0ZaOVtr1MwT8BuCfKJsUBKscIjipX8=; b=c9241WzIL9EQwqasxgR5fCPi+PXU9T0qVoYRO9H/A128pgtokfCk+TDBC3EnwZnxNfr/GQ QYQeRoPmOrKocvgdsQaebo6IeEQUPLa7+8z2xheVbe1nYYOBhsJrSP2wLl3RNMUZihUfNy NBVEU45w4/W5NMcjPwUptEasS14JLXA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-Ssn9pGfTM3atg8LR5btSVQ-1; Fri, 23 Apr 2021 07:15:46 -0400 X-MC-Unique: Ssn9pGfTM3atg8LR5btSVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 675341006706; Fri, 23 Apr 2021 11:15:45 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41A5E687CF; Fri, 23 Apr 2021 11:15:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BA0F5113525D; Fri, 23 Apr 2021 13:15:28 +0200 (CEST) From: Markus Armbruster To: David Hildenbrand Subject: Re: [PATCH v6 12/15] qmp: Include "share" property of memory backends References: <20210421122624.12292-1-david@redhat.com> <20210421122624.12292-13-david@redhat.com> Date: Fri, 23 Apr 2021 13:15:28 +0200 In-Reply-To: <20210421122624.12292-13-david@redhat.com> (David Hildenbrand's message of "Wed, 21 Apr 2021 14:26:21 +0200") Message-ID: <875z0di75b.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , "Dr. David Alan Gilbert" , Greg Kurz , Paolo Bonzini , Stefan Hajnoczi , Murilo Opsfelder Araujo , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" David Hildenbrand writes: > Let's include the property, which can be helpful when debugging, > for example, to spot misuse of MAP_PRIVATE which can result in some ugly > corner cases (e.g., double-memory consumption on shmem). > > Use the same description we also use for describing the property. > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/core/machine-qmp-cmds.c | 1 + > qapi/machine.json | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c > index 68a942595a..d41db5b93b 100644 > --- a/hw/core/machine-qmp-cmds.c > +++ b/hw/core/machine-qmp-cmds.c > @@ -174,6 +174,7 @@ static int query_memdev(Object *obj, void *opaque) > m->merge =3D object_property_get_bool(obj, "merge", &error_abort= ); > m->dump =3D object_property_get_bool(obj, "dump", &error_abort); > m->prealloc =3D object_property_get_bool(obj, "prealloc", &error= _abort); > + m->share =3D object_property_get_bool(obj, "share", &error_abort= ); > m->policy =3D object_property_get_enum(obj, "policy", "HostMemPo= licy", > &error_abort); > host_nodes =3D object_property_get_qobject(obj, > diff --git a/qapi/machine.json b/qapi/machine.json > index 758b901185..32650bfe9e 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -796,6 +796,8 @@ > # > # @prealloc: whether memory was preallocated > # > +# @share: whether memory is private to QEMU or shared (since 6.1) > +# > # @host-nodes: host nodes for its memory policy > # > # @policy: memory policy of memory backend > @@ -809,6 +811,7 @@ > 'merge': 'bool', > 'dump': 'bool', > 'prealloc': 'bool', > + 'share': 'bool', > 'host-nodes': ['uint16'], > 'policy': 'HostMemPolicy' }} Reviewed-by: Markus Armbruster