From: Thomas Gleixner Subject: Re: [PATCHv8 02/34] lib/vdso: make do_hres and do_coarse as __always_inline Date: Fri, 10 Jan 2020 13:02:25 +0100 Message-ID: <875zhja59q.fsf@nanos.tec.linutronix.de> References: <20191112012724.250792-1-dima@arista.com> <20191112012724.250792-3-dima@arista.com> <878smfa66i.fsf@nanos.tec.linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vincenzo Frascino , Dmitry Safonov , linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Adrian Reber , Andrei Vagin , Andy Lutomirski , Arnd Bergmann , Christian Brauner , Cyrill Gorcunov , "Eric W. Biederman" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jeff Dike , Oleg Nesterov , Pavel Emelyanov , Shuah Khan , containers@lists.linux-foundation.org, criu@openvz.org, linux-api@vger.kernel.org, x86@kernel.org List-Id: linux-api@vger.kernel.org Vincenzo Frascino writes: > On 1/10/20 11:42 AM, Thomas Gleixner wrote: >>>> +» » /*·goto·allows·to·avoid·extra·inlining·of·do_hres.·*/ >>>> +» » goto·out_hres; >>> >>> What is the performance impact of "goto out_hres"? >> >> On x86 it's invisible at least in my limited testing. > > On arm64 as well based on mine as well. Shall we keep the code more readable > here (without goto)? The delta patch below makes it readable again and also avoids the double inlining. Quick testing shows no difference. Thanks, tglx 8<--------------- --- a/lib/vdso/gettimeofday.c +++ b/lib/vdso/gettimeofday.c @@ -98,17 +98,15 @@ static __maybe_unused int msk = 1U << clock; if (likely(msk & VDSO_HRES)) { vd = &vd[CS_HRES_COARSE]; -out_hres: - return do_hres(vd, clock, ts); } else if (msk & VDSO_COARSE) { do_coarse(&vd[CS_HRES_COARSE], clock, ts); return 0; } else if (msk & VDSO_RAW) { vd = &vd[CS_RAW]; - /* This goto avoids extra inlining of do_hres. */ - goto out_hres; + } else { + return -1; } - return -1; + return do_hres(vd, clock, ts); } static __maybe_unused int