Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F1DC10F0E for ; Sat, 13 Apr 2019 03:41:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20E4820848 for ; Sat, 13 Apr 2019 03:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E4820848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44h0sw4H76zDqSh for ; Sat, 13 Apr 2019 13:41:08 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44h0rG068nzDqBN for ; Sat, 13 Apr 2019 13:39:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 44h0rF2cmXz9s4V; Sat, 13 Apr 2019 13:39:41 +1000 (AEST) From: Michael Ellerman To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Michael Ellerman Subject: Re: powerpc/64s/radix: Fix radix segment exception handling In-Reply-To: <1555040097.sqg9j51don.astroid@bobo.none> References: <44fRrx4BVsz9s70@ozlabs.org> <1555040097.sqg9j51don.astroid@bobo.none> Date: Sat, 13 Apr 2019 13:39:42 +1000 Message-ID: <875zrivaip.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Aneesh Kumar K . V" , Anton Blanchard Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Nicholas Piggin writes: > Michael Ellerman's on April 11, 2019 12:49 am: >> On Fri, 2019-03-29 at 07:42:57 UTC, Nicholas Piggin wrote: >>> Commit 48e7b76957 ("powerpc/64s/hash: Convert SLB miss handlers to C") >>> broke the radix-mode segment exception handler. In radix mode, this is >>> exception is not an SLB miss, rather it signals that the EA is outside >>> the range translated by any page table. >>> >>> The commit lost the radix feature alternate code patch, which can >>> cause faults to some EAs to kernel BUG at arch/powerpc/mm/slb.c:639! >>> >>> The original radix code would send faults to slb_miss_large_addr, >>> which would end up faulting due to slb_addr_limit being 0. This patch >>> sends radix directly to do_bad_slb_fault, which is a bit clearer. >>> >>> Fixes: 48e7b76957 ("powerpc/64s/hash: Convert SLB miss handlers to C") >>> Cc: Aneesh Kumar K.V >>> Reported-by: Anton Blanchard >>> Signed-off-by: Nicholas Piggin >>> Reviewed-by: Aneesh Kumar K.V >> >> Applied to powerpc fixes, thanks. >> >> https://git.kernel.org/powerpc/c/7100e8704b61247649c50551b965e71d > > I sent a v2 with a selftests that triggers the crash if you want it. > Code was unchanged to no big deal there. Yeah I checked the kernel part was unchanged so stuck with v1. I also sent a self test, which is similar but slightly different to yours, though yours is better in general. I'll try and merge them into one test. cheers