From: Eric Anholt Subject: Re: [PATCH v4 3/4] drm/vc4: Detect and ignore underruns caused by out-of-sync dlists Date: Wed, 06 Feb 2019 15:51:26 -0800 Message-ID: <875ztwlblt.fsf@anholt.net> References: <20190206144906.24304-1-paul.kocialkowski@bootlin.com> <20190206144906.24304-4-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190206144906.24304-4-paul.kocialkowski@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: David Airlie , Daniel Vetter , Maxime Ripard , Thomas Petazzoni , Eben Upton , Paul Kocialkowski List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Paul Kocialkowski writes: > When the pipeline is reconfigured with a different mode, changes take > effect immediately for the CRTC and encoder while the HVS takes some > time to switch the active display list. This results in a period of > time where the pipeline is out of sync, that is very likely to cause > an underrun to be reported. Because the underrun is not related to the > new configuration, reporting it to userspace is a false positive. This seems like a serious issue. How are we enabling a CRTC with the corresponding HVS still scanning out old contents? Did we need to wait for HVS to finish its old frame when we turned off the CRTC, so it's ready to receive the START when it's been set up with the new dlist and the CRTC is turned back on? Or maybe do some sort of reset of that dlist when a crtc is being enabled? If we can't sort that out, it feels to me like we should be enabling the interrupts from the flip_done path (when we know that the HVS is scanning out the new frame) instead of trying to mitigate enabling them too early. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlxbcv4ACgkQtdYpNtH8 nuiTkhAAoKL/4v+X/hB+t3PxDjzBWduI0qDjJKwgKHROEBW2HTrWNd/J71r9+6P4 SSVRoqvFE05GbxX0UxibpcjKpTScfBwhC24Ofkl3FYfNJM+R0HV0VQw7DuUCIQjR KoZ96MgAfeCy72lq0RmDLlXOZLh/DgUauWeN8VUVmT2G+TSpvB00ImU0sv4ZuIZB sFJ59q1JFIPyJs/E3M6K/gtcpHiOvFwakjPDEOPlyFht3+G9PDatXepakHmtA1FK ybx1oid23GMx6Dtd/EAvHPdSPIb7jNlEWvs5nJhlDnWgHnO7Oi+wrb7EdWh/eCyP 0i5dl+7uTdo/MfjIrIGBbViwkgrS5uO8WMHYr9DojqhGIriQ76mEGDxeecrwK8Sm USXtMvClXmMxqskAZCo74zVGC8vg76LAqMffRZT06k54jzTr4XpErmjBe+r/uJ84 SRdWK5z0EXkxREEPXPkFdAVdAxAApqVVbS9o1zfNiYu09CxZwJ5DIOjulXCcJBvX VXvSnyTY6XZs28ScUFIymVH/tlKmqCPgqoiNnz/mP7Km/dgBJr1d5PrnoX82eB3+ Ylp41b44xSuRR8uK/b0UNjneFiFU70gI14G9+G4NYAeF3l67luoNpyvzJ7XTf7Ak TJiDv885cez3w88ShN1klKVx7KjoM9OAHD7SySyh0aGhkdbPVzc= =uaei -----END PGP SIGNATURE----- --=-=-=--