Received: from eggs.gnu.org ([2001:4830:134:3::10]:37669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvlbg-0006pi-HS for qemu-devel@nongnu.org; Mon, 09 Nov 2015 07:31:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvlbc-0006P1-IB for qemu-devel@nongnu.org; Mon, 09 Nov 2015 07:31:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvlbc-0006Ow-DE for qemu-devel@nongnu.org; Mon, 09 Nov 2015 07:31:28 -0500 From: Markus Armbruster References: <1446791754-23823-1-git-send-email-eblake@redhat.com> <1446791754-23823-18-git-send-email-eblake@redhat.com> Date: Mon, 09 Nov 2015 13:31:25 +0100 In-Reply-To: <1446791754-23823-18-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 5 Nov 2015 23:35:41 -0700") Message-ID: <87611bicbm.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v10 17/30] qapi: Simplify QAPISchemaObjectTypeMember.check() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > From: Markus Armbruster > > QAPISchemaObjectTypeMember.check() currently does four things: > > 1. Compute self.type > > 2. Accumulate members in all_members > > Only one caller cares: QAPISchemaObjectType.check() uses it to > compute self.members. The other callers pass a throw-away > accumulator. > > 3. Accumulate a map from names to members in seen > > Only one caller cares: QAPISchemaObjectType.check() uses it to > compute its local variable seen, for self.variants.check(), which > uses it to compute self.variants.tag_member from > self.variants.tag_name. The other callers pass a throw-away > accumulator. > > 4. Check for collisions > > This piggyback on 3: before adding a new entry, we assert it's new. piggybacks (typo is mine) > > Only one caller cares: QAPISchemaObjectType.check() uses it to > assert non-variant members don't clash. > > Simplify QAPISchemaObjectType.check(): move 2.-4. to > QAPISchemaObjectType.check(), and drop parameters all_members and > seen. > > Signed-off-by: Markus Armbruster > Message-Id: <1446559499-26984-2-git-send-email-armbru@redhat.com> > [rebase to earlier changes that moved tag_member.check() of > alternate types] > Signed-off-by: Eric Blake Patch is as good as ever ;)