Received: from eggs.gnu.org ([2001:4830:134:3::10]:54871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4aR-0000Xk-Fu for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:10:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo4aO-0007VL-Bk for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:10:27 -0400 From: Markus Armbruster References: <1444899255-16300-1-git-send-email-thuth@redhat.com> <5623A4C9.90102@ilande.co.uk> Date: Mon, 19 Oct 2015 09:10:17 +0200 In-Reply-To: <5623A4C9.90102@ilande.co.uk> (Mark Cave-Ayland's message of "Sun, 18 Oct 2015 14:55:21 +0100") Message-ID: <876123z63q.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-trivial@nongnu.org, blauwirbel@gmail.com, Thomas Huth , qemu-devel@nongnu.org, pbonzini@redhat.com Mark Cave-Ayland writes: > On 15/10/15 09:54, Thomas Huth wrote: > >> The tcx_initfn() function is already supplied with an >> Object *obj pointer, so there is no need to cast the >> state pointer back to an Object pointer all over the >> place. And while we're at it, also remove the superfluous >> "return;" statement in this function. >> >> Signed-off-by: Thomas Huth [...] > Acked-by: Mark Cave-Ayland > > Note that I'm in the process of moving and therefore connectivity is > going to be poor for the next week and a bit - happy for this to go via > -trivial if that works for everyone? Sure!