From: Markus Armbruster <armbru@redhat.com>
References: <1432294585-5984-1-git-send-email-armbru@redhat.com>
	<1432294585-5984-11-git-send-email-armbru@redhat.com>
	<555FABC7.90701@redhat.com>
Date: Tue, 26 May 2015 11:27:10 +0200
In-Reply-To: <555FABC7.90701@redhat.com> (Eric Blake's message of "Fri, 22 May
	2015 16:20:55 -0600")
Message-ID: <87617feljl.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through
	qmp_check_input_obj()
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 05/22/2015 05:36 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  monitor.c | 19 ++++++++++---------
>>  1 file changed, 10 insertions(+), 9 deletions(-)
>> 
>
>> @@ -4948,27 +4948,27 @@ static QDict *qmp_check_input_obj(QObject *input_obj)
>
>>              }
>>          } else if (!strcmp(arg_name, "id")) {
>>              /* FIXME: check duplicated IDs for async commands */
>
> Is this comment dead, now that you killed async commands?  If so, should
> it be nuked earlier in the series?

I figure you're right.  I'll kill the comment together with asynchronous
commands.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!