From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1432034993-24431-4-git-send-email-dgilbert@redhat.com> (David
	Alan Gilbert's message of "Tue, 19 May 2015 12:29:52 +0100")
References: <1432034993-24431-1-git-send-email-dgilbert@redhat.com>
	<1432034993-24431-4-git-send-email-dgilbert@redhat.com>
Date: Wed, 20 May 2015 10:53:49 +0200
Message-ID: <87617nociq.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 3/4] Add a protective section footer
Reply-To: quintela@redhat.com
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Badly formatted migration streams can go undetected or produce
> misleading errors due to a lock of checking at the end of sections.
> In particular a section that adds an extra 0x00 at the end
> causes what looks like a normal end of stream and thus doesn't produce
> any errors, and something that ends in a 0x01..0x04 kind of look
> like real section headers and then fail when the section parser tries
> to figure out which section they are.  This is made worse by the
> choice of 0x00..0x04 being small numbers that are particularly common
> in normal section data.
>
> This patch adds a section footer consisting of a marker (0x7e - ~)
> followed by the section-id that was also sent in the header.  If
> they mismatch then it throws an error explaining which section was
> being loaded.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>