Received: from eggs.gnu.org ([2001:4830:134:3::10]:42969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn77B-0002Dt-P9 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 11:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn777-0004Mo-T1 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 11:08:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn777-0004Mk-LS for qemu-devel@nongnu.org; Tue, 28 Apr 2015 11:07:57 -0400 From: Markus Armbruster References: <1430218207-7079-1-git-send-email-thuth@redhat.com> Date: Tue, 28 Apr 2015 17:07:53 +0200 In-Reply-To: <1430218207-7079-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Tue, 28 Apr 2015 12:50:07 +0200") Message-ID: <87618gl29i.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] pci: Merge pci_nic_init() into pci_nic_init_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Peter Crosthwaite , qemu-devel@nongnu.org, "Michael S. Tsirkin" Thomas Huth writes: > The error reporting in pci_nic_init() is quite erratic: Some errors > are printed directly with error_report(), and some are passed back > to the caller pci_nic_init_nofail() via an Error pointer. > Since pci_nic_init() is only used by pci_nic_init_nofail(), the > functions can be simply merged to clean up this inconsistency. > > Signed-off-by: Thomas Huth Reviewed-by: Markus Armbruster