From: bjorn@mork.no (=?utf-8?Q?Bj=C3=B8rn_Mork?=) Date: Mon, 03 Nov 2014 11:05:55 +0100 Subject: [PATCH] staging: Fix spacing between function name and parentheses In-Reply-To: <73141.1414888485@turing-police.cc.vt.edu> (Valdis Kletnieks's message of "Sat, 01 Nov 2014 20:34:45 -0400") References: <1412992548-32011-1-git-send-email-xerofoify@gmail.com> <20141011045803.GA3112@sudip-PC> <0AFEF293-AE38-4F6A-BC5E-68AA5D0CFCAB@gmail.com> <54393425.1040409@gmail.com> <20141011135239.GL10301@carfax.org.uk> <4153.1413153252@turing-police.cc.vt.edu> <28D75159261EA145A62C015E176CFEF583736A4E@D8SMAIL.denver.cqg> <73141.1414888485@turing-police.cc.vt.edu> Message-ID: <8761ewzji4.fsf@nemi.mork.no> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org Valdis.Kletnieks at vt.edu writes: > On Mon, 20 Oct 2014 09:17:50 -0000, el_es said: > >> Maybe better to introduce a standard clear marker that >> able people just respond with, to alikes of nick: >> >> REJECTED-by: Name > > We already do something like this. > > You'll on occasion see 'Nacked-By: ...' go by when a kernel hacker > wants to denote their displeasure with a given patch. It's up to the > maintainer to decide how much credence to give to the Nack, based on the > relative reputations of the person submitting the patch and the person > nacking it, and any technical grounds given with the nack. > > So for instance, if Al Viro sticks a Nacked-By: on a submission, it's > going to be *really* hard to get a maintainer to accept the patch, because > Al has a very long history of almost always being right about such things. Yes, but the technical grounds are still the reason the patch is not accepted. Which is why a formalized nak is pointless. It has no value without a verbose explanation of the technical grounds behind it. If Al Viro, or anyone else, use a simple one-line reject message, then I am pretty sure that is because they have already explained their objections somewhere else. I don't think anyone can reject anything merely on their personal reputation. And there is nowhere to record naks, so a standard label just isn't needed. Rejecting is completely different from e.g. Acked-by, which both is a complete explanation ("I am fine with this patch as it is") and is recorded for future reference in the commit message. Bj?rn