Received: from eggs.gnu.org ([2001:4830:134:3::10]:38951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGNtv-0003DA-Fo for qemu-devel@nongnu.org; Thu, 20 Feb 2014 02:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGNtn-0007uu-RM for qemu-devel@nongnu.org; Thu, 20 Feb 2014 02:18:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGNtn-0007tw-J3 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 02:18:23 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1K7ILoR005875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Feb 2014 02:18:21 -0500 From: Markus Armbruster References: <1392822778-4823-1-git-send-email-kwolf@redhat.com> Date: Thu, 20 Feb 2014 08:18:18 +0100 In-Reply-To: <1392822778-4823-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Wed, 19 Feb 2014 16:12:51 +0100") Message-ID: <8761oa8d6t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Kevin Wolf writes: > If you specify the same option more than once (e.g. -o cluster_size=4k > -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This Sounds like perfectly common behavior to me. > series fixes it to either consider all options or to give an error message. Doesn't this break usage like "Compiled-in default is no good for me, create wrapper script setting my defaults followed by "$@", then override them on command line"? > Boolean option can still be given more than once as they aren't problematic > in this respect (ten times -q is still quiet). Unless it's a toggle, but I sure hope we don't have those.