From: OGAWA Hirofumi Subject: Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails Date: Thu, 20 Dec 2012 01:10:01 +0900 Message-ID: <87623ydnvq.fsf@devron.myhome.or.jp> References: <1353504311-6020-1-git-send-email-linkinjeon@gmail.com> <878v9f5ugn.fsf@devron.myhome.or.jp> <87k3sy17vk.fsf@devron.myhome.or.jp> <87txs0x45r.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: (Namjae Jeon's message of "Sat, 15 Dec 2012 19:52:32 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: >> Okay, We will check how we can consolidate the 2 paths to avoid any issue. > Hi OGAWA. > > On checking fat_search_long() logic, it is observed that it performs > name based lookup of the entries in a given directory. > In fat_get_parent(), we do not have such information to use the > existing API to reconstruct the parent inode. > Could you give me some hint or guide to consolidate smoothly > fat_search_long and current traverse_logic ? Hm, start with copy of fat_search_long() and refactoring it. With it, we will be able to avoid the fixed bugs. After that, we might be able to merge those somehow. Well, I'm not pretty sure without doing it actually though. Thanks. -- OGAWA Hirofumi