From: Chris Ball Subject: Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5 Date: Thu, 19 Jul 2012 02:46:11 -0400 Message-ID: <87629k9rkc.fsf@octavius.laptop.org> References: <1340872367-16206-1-git-send-email-ygardi@codeaurora.org> <1340872367-16206-3-git-send-email-ygardi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1340872367-16206-3-git-send-email-ygardi@codeaurora.org> (Yaniv Gardi's message of "Thu, 28 Jun 2012 11:32:46 +0300") Sender: linux-arm-msm-owner@vger.kernel.org To: Yaniv Gardi Cc: linux-mmc@vger.kernel.org, merez@codeaurora.org, linux-arm-msm@vger.kernel.org, open list List-Id: linux-mmc@vger.kernel.org Hi Yaniv, On Thu, Jun 28 2012, Yaniv Gardi wrote: > This feature delete the unmap memory region of the eMMC card, > by writing to a specific register in the EXT_CSD > unmap region is the memory region that were previously deleted > (by erase, trim or discard operation) > > Signed-off-by: Yaniv Gardi Did you reply to Chuanxiao's review comments yet? He said: "So to implement your scenario, how about only add mmc_blk_issue_sanitize_rq() for REQ_SANITIZE but not touch mmc_blk_issue_secdiscard_rq()? With your changes in mmc_blk_issue_secdiscard_rq(), eMMC4.5 device will be failed to operate secure trim/erase for REQ_SECURE request." at: http://thread.gmane.org/gmane.linux.kernel.mmc/14822/focus=14880 Thanks, - Chris. -- Chris Ball One Laptop Per Child