From: OGAWA Hirofumi Subject: xfs: d_add_ci() and dcache handling Date: Sun, 17 Aug 2008 11:52:52 +0900 Message-ID: <8763q0fj3v.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:52013 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbYHQCw5 (ORCPT ); Sat, 16 Aug 2008 22:52:57 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, I'm playing with dcache codes recently. Then, by chance, I found newly added dcache handling looks a bit strange. xfs_vn_ci_lookup() doesn't create negative dentry (doesn't d_add(dentry, NULL)), it would be no problem. But creation path also doesn't do d_rehash() for it, even if it's passed the non d_rehash()ed dentry. I.e. it just does d_instantiate(). Although I don't know whether it's a intent or not, maybe CI version wants to do d_add() instead of d_instantiate()? Thanks. -- OGAWA Hirofumi