From: OGAWA Hirofumi Date: Tue, 31 Oct 2006 05:03:48 +0900 Subject: [Cluster-devel] [PATCH 1/4] Cleanup read_pages() Message-ID: <8764e1muzf.fsf@duaron.myhome.or.jp> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Current read_pages() assume ->readpages() frees the passed pages. This patch free the pages in ->read_pages(), if those were remaining in the pages_list. So, readpages() just can ignore the remaining pages in pages_list. Signed-off-by: OGAWA Hirofumi --- mm/readahead.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN mm/readahead.c~readpages-fixes mm/readahead.c --- linux-2.6/mm/readahead.c~readpages-fixes 2006-10-31 04:45:38.000000000 +0900 +++ linux-2.6-hirofumi/mm/readahead.c 2006-10-31 04:46:37.000000000 +0900 @@ -167,6 +167,8 @@ static int read_pages(struct address_spa if (mapping->a_ops->readpages) { ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages); + /* Clean up the remaining pages */ + put_pages_list(pages); goto out; } _