Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E50F3C388F7 for ; Mon, 9 Nov 2020 13:05:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4610220684 for ; Mon, 9 Nov 2020 13:05:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rkcCHFrK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="tGp5ZOan" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4610220684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rK00PNUlhwE2wIF1Z/n77m8D7AVGh197XfvM6iqpMC0=; b=rkcCHFrKfBLDHM2m0NExlkhw8 VSCJ0iLiDH6y+KP/UAMS+5uzksDyXEXrDiN14HrFqH3R+uXcoXpGk0XM69v6iPnU+NqKVMhZ/nPh7 /JkK352Z+MYh21P/29BmLwiMiOq5CKVVQHVwhY6csF+izAolxH167/s1KsWOzSt10YCK9jJ4ULWTd yobxDe7L7Oja5rVFZTqaezJnF89pO00ruQ6cUBmiY9tXv+OC1NsrjbJcVWelyE9MaybPdGlfWlqEq Qj5RoUn+w2E55NcBFYgGWivVigvQV3VJrTu4ee5w/MDRl8IyfkF3PB+sx6otbKEoANeFnvsQ01bQx N6LwKlDDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc6q5-0006tm-MH; Mon, 09 Nov 2020 13:04:05 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc6q2-0006tC-Mz for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 13:04:04 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A9CuYAK013014; Mon, 9 Nov 2020 14:03:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=uliSc5A3vlTADmZoc0p1nem0ouQD8B+Qw8ci3FCn8LQ=; b=tGp5ZOanOxiLzuVyk7nDek1MQggdIbdX7UkqOuTw0PbtyzoDKseOWxKNnUefKwhh8RhH 7Bf0caCo+WuBl6GvDu/+d+Ns3mwXe8aWUDYdGUYeyASS65Imc0NkYG9L3L1LkjWSoWqw BR7daSh77WmjQ1ai/FS6RKXsV4Xa4x4ZOT7cT+4xfaTHhX1Lm6/27GGqAloTLL/kGCQw HtT2PXS0sLxiTnhbAOpu58iipVdqNZA3o+WhZBAvzHNp5wK9TX0MvLUSWuhRi1TQt8DJ O6NyMrajlvIscWyHkW0b4bC+Bn4eQjuK3UN7NaVzhZvgiQ2DXhybBDFczttN1ErbKaSn 2w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 34nj80j267-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Nov 2020 14:03:58 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3536210002A; Mon, 9 Nov 2020 14:03:58 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1C88D2AD9FE; Mon, 9 Nov 2020 14:03:58 +0100 (CET) Received: from lmecxl0912.lme.st.com (10.75.127.51) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Nov 2020 14:03:57 +0100 Subject: Re: [PATCH] ARM: dts: stm32: Fix TA3-GPIO-C key on STM32MP1 DHCOM PDK2 To: Marek Vasut , References: <20201008193538.129401-1-marex@denx.de> From: Alexandre Torgue Message-ID: <8775d419-0ca7-3098-41ed-ece54ee4ef4c@st.com> Date: Mon, 9 Nov 2020 14:03:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201008193538.129401-1-marex@denx.de> Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-09_02:2020-11-05, 2020-11-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_080403_327025_8DC54107 X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Patrick Delaunay , Patrice Chotard , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek On 10/8/20 9:35 PM, Marek Vasut wrote: > On the prototype DHCOM, the TA3-GPIO-C button was connected to pin PI11 of > the STM32MP15xx, however on the production SoM this was changed to pin PG0 > to free up the IRQ line 11 for LAN8710i PHY IRQ. Update the connection in > the DT. Since the IRQ line 0 is used for PMIC as well and cannot be shared > with the button, make the button polled. > > Fixes: 87cabf9405cb ("ARM: dts: stm32: Add GPIO keys for STM32MP1 DHCOM PDK2") > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Maxime Coquelin > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > index 5dff24e39af8..9a0a59678097 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > @@ -46,6 +46,16 @@ > linux,code = ; > gpios = <&gpiof 3 GPIO_ACTIVE_LOW>; > }; > + > + /* > + * The EXTi IRQ line 0 is shared with PMIC, > + * so mark this as polled GPIO key. > + */ > + button-2 { > + label = "TA3-GPIO-C"; > + linux,code = ; > + gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; > + }; > }; > > gpio-keys { > @@ -59,13 +69,6 @@ > wakeup-source; > }; > > - button-2 { > - label = "TA3-GPIO-C"; > - linux,code = ; > - gpios = <&gpioi 11 GPIO_ACTIVE_LOW>; > - wakeup-source; > - }; > - > button-3 { > label = "TA4-GPIO-D"; > linux,code = ; > Applied on stm32-dt-for-v5.10-fixes. regards alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel