From: Francisco Jerez Subject: Re: [PATCH v3 2/2] drm/i915/tgl: MOCS table update Date: Tue, 12 Nov 2019 15:20:03 -0800 Message-ID: <877e44znq4.fsf@riseup.net> References: <20191112224757.25116-1-matthew.d.roper@intel.com> <20191112224757.25116-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1270674464==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 233EA89CB9 for ; Tue, 12 Nov 2019 23:19:31 +0000 (UTC) In-Reply-To: <20191112224757.25116-2-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org --===============1270674464== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Matt Roper writes: > The bspec was just updated with a minor correction to entry 61 (it > shouldn't have had the SCF bit set). > > v2: > - Add a MOCS_ENTRY_UNUSED() and use it to declare the > explicitly-reserved MOCS entries. (Lucas) > - Move the warning suppression from the Makefile to a #pragma that only > affects the TGL table. (Lucas) > > v3: > - Entries 16 and 17 are identical to ICL now, so no need to explicitly > adjust them (or mess with compiler warning overrides). > > Bspec: 45101 > Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake") > Cc: Tomasz Lis > Cc: Lucas De Marchi > Cc: Francisco Jerez > Cc: Jon Bloomfield > Signed-off-by: Matt Roper Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/= gt/intel_mocs.c > index 06e2adbf27be..2b977991b785 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -263,7 +263,7 @@ static const struct drm_i915_mocs_entry tigerlake_moc= s_table[] =3D { > L3_1_UC), > /* HW Special Case (Displayable) */ > MOCS_ENTRY(61, > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), > + LE_1_UC | LE_TC_1_LLC, > L3_3_WB), > }; >=20=20 > --=20 > 2.21.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXcs+IwAKCRCDmTidfVK/ W+R0AP9F+MEUdw0NwDSTEVrZtjtvu29Kx31xpCe4ncHqZZf4rwD3f1p1Ar1KN0/H P2IzphO6OOCC0PlB4negz00871wdKg== =xOHm -----END PGP SIGNATURE----- --==-=-=-- --===============1270674464== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1270674464==--