Received: from eggs.gnu.org ([209.51.188.92]:35458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDVnX-0001v7-UN for qemu-devel@nongnu.org; Mon, 08 Apr 2019 11:03:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDVnX-0002pb-2h for qemu-devel@nongnu.org; Mon, 08 Apr 2019 11:02:59 -0400 From: Markus Armbruster References: <20190204231815.29661-1-philmd@redhat.com> <20190204231815.29661-6-philmd@redhat.com> Date: Mon, 08 Apr 2019 17:02:44 +0200 In-Reply-To: <20190204231815.29661-6-philmd@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Tue, 5 Feb 2019 00:18:09 +0100") Message-ID: <877ec4o7zf.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus declarations into a new header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Peter Maydell , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Rob Herring , Magnus Damm , Joel Stanley , Richard Henderson , Thomas Huth , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , =?utf-8?Q?C=C3=A9dric?= Le Goater , David Gibson , Andrew Jeffery , Bastian Koppelmann , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Igor Mitsyanko , Michael Walle , qemu-ppc@nongnu.org, Jan Kiszka , Aurelien Jarno Philippe Mathieu-Daud=C3=A9 writes: > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Not at all this patch's problem, but I can't withhold these gems from your admiring eyes: hw/arm/nseries.c: cbus_attach(cbus, s->retu =3D retu_init(retu_irq, 1)); hw/arm/nseries.c: cbus_attach(cbus, s->tahvo =3D tahvo_init(tahvo_irq, 1= ));