Received: from eggs.gnu.org ([2001:4830:134:3::10]:32881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjTzI-0000qn-VM for qemu-devel@nongnu.org; Mon, 12 Sep 2016 12:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjTzD-0007b8-3h for qemu-devel@nongnu.org; Mon, 12 Sep 2016 12:21:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjTzC-0007ay-Un for qemu-devel@nongnu.org; Mon, 12 Sep 2016 12:21:35 -0400 From: Markus Armbruster References: <1473088600-17930-1-git-send-email-berrange@redhat.com> <1473088600-17930-6-git-send-email-berrange@redhat.com> Date: Mon, 12 Sep 2016 18:21:32 +0200 In-Reply-To: <1473088600-17930-6-git-send-email-berrange@redhat.com> (Daniel P. Berrange's message of "Mon, 5 Sep 2016 16:16:39 +0100") Message-ID: <877fahozqr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Max Reitz , =?utf-8?Q?Marc?= =?utf-8?Q?-Andr=C3=A9?= Lureau , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= "Daniel P. Berrange" writes: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for QmpInputVisitor > that will set it up such that it expects a QString for > all scalar types instead. > > This makes it possible to use QmpInputVisitor with a > QDict produced from QemuOpts, where everything is in > string format. > > Reviewed-by: Marc-Andr=C3=A9 Lureau > Signed-off-by: Daniel P. Berrange Ignorant question: is this used by the next patch?