Received: from eggs.gnu.org ([2001:4830:134:3::10]:46469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztu6e-0003LD-BW for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:11:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztu6a-0006LE-9E for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:11:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztu6a-0006L9-3p for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:11:44 -0500 From: Markus Armbruster References: <1446618049-13596-1-git-send-email-eblake@redhat.com> <1446618049-13596-8-git-send-email-eblake@redhat.com> Date: Wed, 04 Nov 2015 10:11:40 +0100 In-Reply-To: <1446618049-13596-8-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 3 Nov 2015 23:20:29 -0700") Message-ID: <877flyt9gz.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 07/27] qapi: More tests of input arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > Our testsuite had no coverage of empty arrays, nor of what > happens when the input does not match the expected type. > Useful to have, especially if we start changing the visitor > contracts. > > Signed-off-by: Eric Blake > > --- > v9: move earlier in series (was 16/17) > v8: no change > v7: no change > v6: new patch > --- > tests/test-qmp-input-visitor.c | 51 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) Should we update test-qmp-input-strict.c as well? Patch looks good.