Received: from eggs.gnu.org ([2001:4830:134:3::10]:49027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Dc4-00066L-BG for qemu-devel@nongnu.org; Wed, 17 Jun 2015 09:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Dby-0007Wq-RY for qemu-devel@nongnu.org; Wed, 17 Jun 2015 09:42:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Dby-0007Wc-Mp for qemu-devel@nongnu.org; Wed, 17 Jun 2015 09:42:38 -0400 From: Markus Armbruster References: <87fv5qg448.fsf@blackfin.pond.sub.org> <55816180.4090101@gmail.com> Date: Wed, 17 Jun 2015 15:42:36 +0200 In-Reply-To: <55816180.4090101@gmail.com> (=?utf-8?B?IkvFkXbDoWfDsyBab2x0?= =?utf-8?B?w6FuIidz?= message of "Wed, 17 Jun 2015 14:01:04 +0200") Message-ID: <877fr230z7.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?= Cc: Michael Roth , Gerd Hoffmann , qemu-devel@nongnu.org "K=C5=91v=C3=A1g=C3=B3 Zolt=C3=A1n" writes: > 2015-06-17 09:56 keltez=C3=A9ssel, Markus Armbruster =C3=ADrta: >> "K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n" writes: >> >>> Simple visitor that recursively allocates structures with only optional >>> variables. Unions are initialized to the first type specified. Other non >>> optional types are not supported. >> >> Sounds dubious :) >> >> Can you explain why it's useful? I guess later patches provide an >> example. > > Oh, crap, ignore this commit. Just realized that in the refactorings I > did I removed all references to this visitor... so it's not needed. Glad I asked before reviewing the code :)