Received: from eggs.gnu.org ([2001:4830:134:3::10]:52150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtIVt-0000xx-W6 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 09:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtIVo-0002kh-3F for qemu-devel@nongnu.org; Wed, 18 Dec 2013 09:54:17 -0500 From: Markus Armbruster References: <1385654544-1774-1-git-send-email-armbru@redhat.com> Date: Wed, 18 Dec 2013 15:54:06 +0100 In-Reply-To: <1385654544-1774-1-git-send-email-armbru@redhat.com> (armbru@redhat.com's message of "Thu, 28 Nov 2013 17:02:24 +0100") Message-ID: <877gb2gqgh.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: device_add crashes on non-device driver name, fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: afaerber@suse.de, aliguori@amazon.com, qemu-stable@nongnu.org Ping? armbru@redhat.com writes: > From: Markus Armbruster > > Watch this: > > $ upstream-qemu -nodefaults -S -display none -monitor stdio > QEMU 1.7.50 monitor - type 'help' for more information > (qemu) device_add rng-egd > /work/armbru/qemu/qdev-monitor.c:491:qdev_device_add: Object 0x2089b00 is not an instance of type device > Aborted (core dumped) > > Crashes because "rng-egd" exists, but isn't a subtype of TYPE_DEVICE. > Broken in commit 18b6dad. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Markus Armbruster > --- > qdev-monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qdev-monitor.c b/qdev-monitor.c > index dc37a43..90a0cea 100644 > --- a/qdev-monitor.c > +++ b/qdev-monitor.c > @@ -477,7 +477,7 @@ DeviceState *qdev_device_add(QemuOpts *opts) > } > } > > - if (!oc) { > + if (!object_class_dynamic_cast(oc, TYPE_DEVICE)) { > qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "device type"); > return NULL; > }