Received: from eggs.gnu.org ([208.118.235.92]:49649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPqFD-00023R-DU for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPqF5-0001pq-NC for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:19:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPqF5-0001pg-FC for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:18:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3A8Isjw004412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Apr 2013 04:18:55 -0400 From: Markus Armbruster References: Date: Wed, 10 Apr 2013 10:18:53 +0200 In-Reply-To: (Pavel Hrdina's message of "Fri, 29 Mar 2013 15:12:27 +0100") Message-ID: <877gkavlw2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Pavel Hrdina writes: > This patch series convert the savevm command into qapi and introduce QMP > command vm-snapshot-save. > It also rewrite error report for functions used by this command. > > The last patch introduce new functionality of savevm that you cannot override > existing snapshot without using 'force' parameter. > > If non-blocking behaviour of this command is required and we cannot wait > until live snapshots will be finished, I could improve this basic command > to be non-blocking. I had a couple of questions, but the code looks generally solid. The most serious question is about the design of the QMP command. We need to reach consensus there before we can make further progress.