From: OGAWA Hirofumi Subject: Re: [PATCH v6 4/7] fat: restructure export_operations Date: Mon, 18 Feb 2013 20:42:24 +0900 Message-ID: <877gm526hr.fsf@devron.myhome.or.jp> References: <1360422145-12280-1-git-send-email-linkinjeon@gmail.com> <87fw0t3mq0.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: <87fw0t3mq0.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Mon, 18 Feb 2013 20:06:31 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org OGAWA Hirofumi writes: >> + if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) { >> + *lenp = FAT_FID_SIZE_WITH_PARENT; >> + return 255; >> + } else if (len < FAT_FID_SIZE_WITHOUT_PARENT) { >> + *lenp = FAT_FID_SIZE_WITHOUT_PARENT; >> + return 255; We would be better to use FILEID_INVALID on all places, instead of 255. -- OGAWA Hirofumi