From: OGAWA Hirofumi Subject: Re: [PATCH v2 3/4] fat: mark superblock as dirty less often Date: Sat, 14 Apr 2012 19:37:56 +0900 Message-ID: <877gxiha4b.fsf@devron.myhome.or.jp> References: <1334326795-2446-1-git-send-email-dedekind1@gmail.com> <1334326795-2446-4-git-send-email-dedekind1@gmail.com> <87k41ihdub.fsf@devron.myhome.or.jp> <1334399070.2263.3.camel@koala> Mime-Version: 1.0 Content-Type: text/plain Cc: Andrew Morton , Linux Kernel Maling List , Linux FS Maling List , Artem Bityutskiy To: dedekind1@gmail.com Return-path: In-Reply-To: <1334399070.2263.3.camel@koala> (Artem Bityutskiy's message of "Sat, 14 Apr 2012 13:24:17 +0300") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Artem Bityutskiy writes: > On Sat, 2012-04-14 at 18:17 +0900, OGAWA Hirofumi wrote: >> Artem Bityutskiy writes: >> >> > From: Artem Bityutskiy >> > >> > This patch is a preparation for further changes. It touches few functions >> > in fatent.c and prevents them from marking the superblock as dirty >> > unnecessarily often. Namely, instead of marking it as dirty in the internal >> > tight loops - do it only once at the end of the functions. And instead of >> > marking it as dirty while holding the FAT table lock, do it >> > outside the lock. >> > >> > The reason for this patch is that marking the superblock as dirty will soon >> > become a little bit heavier operation, so it is cleaner to do this >> > only when it >> > is necessary. >> >> For it, please use local variable like, >> >> >> { >> int fsinfo_dirty = 0; >> >> while (1) { >> change free_clusters >> fsinfo_dirty = 1; >> } >> >> if (fsinfo_dirty) >> mark_fsinfo_dirty() >> } >> >> instead of dirty it always. > > But could you please explain why do we need an extra variable? What is > the problem with doing all our FAT table changes and then marking the > FSINFO as dirty? Above example may not be proper. I meant please dirty FSINFO only if necessary. Your patch seems to be dirty even if code didn't change FSINFO. -- OGAWA Hirofumi