From: Dmitry Subject: Re: [PATCH 04/11] quota: make dquot lists per-sb Date: Wed, 06 Oct 2010 13:39:58 +0400 Message-ID: <877hhvaccx.fsf@dmon-lap.sw.ru> References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com> <1286302827-31043-5-git-send-email-dmonakhov@gmail.com> <20101006085744.GD7295@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org, Dmitry Monakhov To: Christoph Hellwig Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:14703 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349Ab0JFJlL (ORCPT ); Wed, 6 Oct 2010 05:41:11 -0400 In-Reply-To: <20101006085744.GD7295@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 6 Oct 2010 04:57:44 -0400, Christoph Hellwig wrote: > On Tue, Oct 05, 2010 at 10:20:20PM +0400, Dmitry Monakhov wrote: > > Currently quota lists are global which is very bad for scalability. > > * inuse_lists -> sb->s_dquot->dq_inuse_list > > * free_lists -> sb->s_dquot->dq_free_lists > > * Add per sb lock for quota's lists protection > > > > Do not remove dq_lists_lock is used now only for protecting quota_hash > > I'm not a big fan of adding tons of new fields to the generic superblock > for a handfull filesystems actually using it. Can you look into > introducing a quota_sb structure that the few filesystems that use > it can embedd into their superblock? Yep, seems reasonable. Will handle that in next version. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html