Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EuErn-0004yq-G8 for qemu-devel@nongnu.org; Wed, 04 Jan 2006 15:04:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EuErk-0004y5-6f for qemu-devel@nongnu.org; Wed, 04 Jan 2006 15:04:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EuErj-0004xs-OL for qemu-devel@nongnu.org; Wed, 04 Jan 2006 15:04:11 -0500 Received: from [212.20.112.165] (helo=pavel.int.rudna.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EuEtA-0002qB-Up for qemu-devel@nongnu.org; Wed, 04 Jan 2006 15:05:41 -0500 From: Pavel@Janik.cz (Pavel =?iso-8859-2?Q?Jan=EDk?=) Date: Wed, 04 Jan 2006 21:01:27 +0100 Message-ID: <877j9fzs1b.fsf@Janik.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] block-cloop.c: fix signedness gcc4 warning Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, gcc4 is more picky about signedness. Please apply. --- block-cloop.c 18 Dec 2004 10:42:44 +0100 1.2 +++ block-cloop.c 04 Jan 2006 20:38:09 +0100=09 @@ -32,8 +32,8 @@ uint64_t* offsets; uint32_t sectors_per_block; uint32_t current_block; - char* compressed_block; - char* uncompressed_block; + unsigned char* compressed_block; + unsigned char* uncompressed_block; z_stream zstream; } BDRVCloopState; =20 @@ -89,9 +89,9 @@ } =20 /* initialize zlib engine */ - if(!(s->compressed_block=3D(char*)malloc(max_compressed_block_size+1= ))) + if(!(s->compressed_block=3D(unsigned char*)malloc(max_compressed_blo= ck_size+1))) goto cloop_close; - if(!(s->uncompressed_block=3D(char*)malloc(s->block_size))) + if(!(s->uncompressed_block=3D(unsigned char*)malloc(s->block_size))) goto cloop_close; if(inflateInit(&s->zstream) !=3D Z_OK) goto cloop_close; --=20 Pavel Jan=EDk Write and test a big program in small pieces. -- The Elements of Programming Style (Kernighan & Plaug= her)