Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC59DC7EE24 for ; Tue, 6 Jun 2023 12:37:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9444B822; Tue, 6 Jun 2023 14:36:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9444B822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686055029; bh=Xy6ssZaCe3RYiLzHBR7bawSyF583K8GqhO9fA+JAscs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=F47qI3gLH4Je9maQLRKR3FYHKw0H1GegbgXl8mXcdNrqBKod1I0Y0J0iGLQ/Vjdif qpgF+9qGmlBmqca8gP9dBm/eykS0rXwKxZelXl+ZYGrpA22Ckog1ay8tR7MZxxrstM 1dy3yYUbnzEHKVeEpg/PccLb5GdZTPaGVk3YS5Hg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 77067F80520; Tue, 6 Jun 2023 14:35:53 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 04628F80199; Tue, 6 Jun 2023 14:35:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 495C3F80199; Tue, 6 Jun 2023 14:35:49 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2CF95F800C8 for ; Tue, 6 Jun 2023 14:35:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2CF95F800C8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t6M8Ndlw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7M63XcvT Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6E628219A2; Tue, 6 Jun 2023 12:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686054938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyvPm/70IVaTMkUngj2z+Ro7QVFz2mZ6FwZUOscZ5nc=; b=t6M8Ndlwif7NqWQUEjQpcLCoaeW6BQOoJ1lkQ5XLwCrZS/v56NgtrnQSYQ0EiVsiTjR6+o 80mkYVWK1GS9rWsH+8AXAG5mrgINuPmuQSEaw74uEFDXB5xAZoag9smVMIPbrun71W3/hg 853tOiDY5XtAm2y1U1Fly/PJOLDRBY0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686054938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyvPm/70IVaTMkUngj2z+Ro7QVFz2mZ6FwZUOscZ5nc=; b=7M63XcvTRamLiEq/OYBCTPEcfRdDjIlMcZ7cg4AHMcXmBM3gfMclF6jBs9KBp5r0w910Oi GHcx6VeUTOupG5AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4604713519; Tue, 6 Jun 2023 12:35:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2uufDhoof2TSPgAAMHmgww (envelope-from ); Tue, 06 Jun 2023 12:35:38 +0000 Date: Tue, 06 Jun 2023 14:35:37 +0200 Message-ID: <878rcwsr8m.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: control: Keep the previous numid at snd_ctl_rename_id() In-Reply-To: <82b3dc7a-16f7-6c8d-766c-acd219e60f5b@perex.cz> References: <20230606094035.14808-1-tiwai@suse.de> <82b3dc7a-16f7-6c8d-766c-acd219e60f5b@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: X5MFJHKYS7UGBQSBZZOP522EMVFGB4UP X-Message-ID-Hash: X5MFJHKYS7UGBQSBZZOP522EMVFGB4UP X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 06 Jun 2023 13:15:20 +0200, Jaroslav Kysela wrote: > > On 06. 06. 23 11:40, Takashi Iwai wrote: > > We don't need to change the numid at each time snd_ctl_rename_id() is > > called, as the control element size itself doesn't change. Let's keep > > the previous numid value. > > I would also highlight in the comment that snd_ctl_rename_id() should > be used only in the card initialization phase. It may cause issues > with the user space (persistent numid) for the dynamic controls. Sounds good. I'll add the note in the commit. > Reviewed-by: Jaroslav Kysela Thanks! Takashi