Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91069C433F5 for ; Fri, 22 Apr 2022 10:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356293AbiDVKLU (ORCPT ); Fri, 22 Apr 2022 06:11:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233539AbiDVKLU (ORCPT ); Fri, 22 Apr 2022 06:11:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF7053A7B for ; Fri, 22 Apr 2022 03:08:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B34F61E22 for ; Fri, 22 Apr 2022 10:08:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DA11C385A4; Fri, 22 Apr 2022 10:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650622106; bh=gJBUkmsyumVWt+zZOJ0eB/u4OtmHxcnEmlKgLhLhNZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RCAo1AiHDYYoQKNfAtP2RfwkBsKK0Xt8w0xViLZtG0W9AFGGz8YypKpkjU/0qUMC3 vCOefB+s7Im6YBLHq5yDaXSCPsK1C8znZBU/7kWgrRrPA2vI+etGEZsAKOqzAdqt/0 440vm6JqTee6WFfZM+Ia7gqf9nplSVzcJskTY3QY0PQnAHMs92Z8/mKCbXdxbS2Gfk JnCK+2wbwDiMFimuSrjC6mOzYsSV6IJXPaQy4b1HxFiGBvS/gogQUFT42n1sKk8D4g Rn0qW88fDHLVzeKTH9ahGVpC+NMvV1OrrozI6tExzoMBllsYnYjPVncQrzFk3vZCKa 74pLU3LGlWrPw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nhqDA-0067z0-CU; Fri, 22 Apr 2022 11:08:24 +0100 Date: Fri, 22 Apr 2022 11:08:24 +0100 Message-ID: <878rrxa0rr.wl-maz@kernel.org> From: Marc Zyngier To: Fabien DESSENNE Cc: Marek Vasut , , Alexandre Torgue , Linus Walleij , , Subject: Re: [PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested In-Reply-To: <5f3aa91e-0ca3-a13a-1ea3-daae982b3d8f@foss.st.com> References: <20220421140827.214088-1-marex@denx.de> <5f3aa91e-0ca3-a13a-1ea3-daae982b3d8f@foss.st.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fabien.dessenne@foss.st.com, marex@denx.de, linux-gpio@vger.kernel.org, alexandre.torgue@foss.st.com, linus.walleij@linaro.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 22 Apr 2022 10:20:36 +0100, Fabien DESSENNE wrote: > > Hi Marek, > > I agree there is something wrong with the clock management in IRQ > context here and your patch goes in the right way. > There are also some other problems regarding performance (enabling / > disabling clock each time we want to change the IO value, ...). > For these both issues I have a patch, which basically keeps the GPIO > clocks enabled from probe. > I did not have time to submit it, but, considering your concerns, I > will do it in the coming days. > For the time being I suggest that we do not apply your patch. Why? This fixes a glaring issue, and there are no alternatives at the moment. So if there is something to improve on, please base your patch on top of Marek's. Thanks, M. -- Without deviation from the norm, progress is not possible.