Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjm1H-0001hx-Dg for ath11k@lists.infradead.org; Mon, 30 Nov 2020 16:27:25 +0000 From: Kalle Valo Subject: Re: [PATCH v2] ath11k: fix rmmod failure if qmi sequence fails References: <1605076699-21924-1-git-send-email-akolli@codeaurora.org> <87mtz5pm8a.fsf@codeaurora.org> <013d9ee1c0f88863013f2672b6b2197a@codeaurora.org> Date: Mon, 30 Nov 2020 18:27:08 +0200 In-Reply-To: <013d9ee1c0f88863013f2672b6b2197a@codeaurora.org> (akolli@codeaurora.org's message of "Mon, 30 Nov 2020 19:25:21 +0530") Message-ID: <878saikdyb.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: akolli@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org akolli@codeaurora.org writes: > On 2020-11-25 19:33, Kalle Valo wrote: >> Anilkumar Kolli writes: >> >>> QMI sequence fails if caldata file is not available. >>> It is observed that 'rmmod ath11k' fails if qmi message fails. >>> With this patch rmmod/insmod is working. >>> >>> Logs: >>> Direct firmware load for IPQ8074/caldata.bin failed with error -2 >>> Falling back to user helper >>> qmi failed to load CAL: IPQ8074/caldata.bin >>> qmi failed to load board data file:-11 >>> >>> Tested-on: IPQ8074 hw2.0 AHB >>> WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1 >>> >>> Signed-off-by: Anilkumar Kolli >> >> With this patch reloading ath11k (which has worked fine before) crashes >> the kernel on QCA6390 hw2.0: >> >> Nov 25 16:00:52 nuc1 [ 393.188277] BUG: unable to handle page fault >> for address: ffffffffc05b8e38 >> Nov 25 16:00:52 nuc1 [ 393.188300] #PF: supervisor read access in >> kernel mode >> Nov 25 16:00:52 nuc1 [ 393.188312] #PF: error_code(0x0000) - >> not-present page > > I will test this in QCA6390 and update. > Which branch should I use for testing. master or > ath11k-qca6390-bringup ? Please use master branch. ath11k-qca6390-bringup is just a temporary branch for collecting all important QCA6390 patches in one place. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k