Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: s2255 & stkwebcam: fix oops with malicious USB descriptors From: =?utf-8?q?Bj=C3=B8rn_Mork?= Message-Id: <878swf645i.fsf@miraculix.mork.no> Date: Fri, 12 Apr 2019 10:04:09 +0200 To: Young Xiao <92siuyang@gmail.com> Cc: kbuild-all@01.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, greg@kroah.com, mchehab@kernel.org, keescook@chromium.org, hans.verkuil@cisco.com, Young Xiao List-ID: UGxlYXNlIG1hcmsgdXBkYXRlZCBwYXRjaGVzIHdpdGggYSB2ZXJzaW9uIG51bWJlciBvciBzb21l IG90aGVyCmluZGljYXRpb24gdGhhdCBpdCByZXBsYWNlcyBhIHByZXZpb3VzIHBhdGNoLiAgSW5j bHVkaW5nIGEgc3VtbWFyeSBvZgpjaGFuZ2VzIGlzIGFsc28gbm9ybWFsLgoKQW5kIHNwZWFraW5n IG9mIG5vcm1hbDogIFdlIGRvIGJ1aWxkIHRlc3Qgb3VyIHBhdGNoZXMsIGRvbid0IHdlPwoKCllv dW5nIFhpYW8gPDkyc2l1eWFuZ0BnbWFpbC5jb20+IHdyaXRlczoKCj4gRnJvbTogWW91bmcgWGlh byA8WWFuZ1g5MkBob3RtYWlsLmNvbT4KPgo+IFRoZSBkcml2ZXIgZXhwZWN0cyBhdCBsZWFzdCBv bmUgdmFsaWQgZW5kcG9pbnQuIElmIGdpdmVuCj4gbWFsaWNpb3VzIGRlc2NyaXB0b3JzIHRoYXQg c3BlY2lmeSAwIGZvciB0aGUgbnVtYmVyIG9mIGVuZHBvaW50cywKPiBpdCB3aWxsIGNyYXNoIGlu IHRoZSBwcm9iZSBmdW5jdGlvbi4KCk5vLCBpdCB3b24ndC4gIERpZCB5b3UgdGVzdCB0aGlzPyAg Q2FuIHlvdSBwcm92aWRlIHRoZSBvb3BzPwoKVGhpcyBpcyBwZXJmZWN0bHkgZmluZSBhcyBpdCBp czoKCglkZXYgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgczIyNTVfZGV2KSwgR0ZQX0tFUk5FTCk7 Ci4uCglmb3IgKGkgPSAwOyBpIDwgaWZhY2VfZGVzYy0+ZGVzYy5iTnVtRW5kcG9pbnRzOyArK2kp IHsKCQllbmRwb2ludCA9ICZpZmFjZV9kZXNjLT5lbmRwb2ludFtpXS5kZXNjOwoJCWlmICghZGV2 LT5yZWFkX2VuZHBvaW50ICYmIHVzYl9lbmRwb2ludF9pc19idWxrX2luKGVuZHBvaW50KSkgewoJ CQkvKiB3ZSBmb3VuZCB0aGUgYnVsayBpbiBlbmRwb2ludCAqLwoJCQlkZXYtPnJlYWRfZW5kcG9p bnQgPSBlbmRwb2ludC0+YkVuZHBvaW50QWRkcmVzczsKCQl9Cgl9CgoJaWYgKCFkZXYtPnJlYWRf ZW5kcG9pbnQpIHsKCQlkZXZfZXJyKCZpbnRlcmZhY2UtPmRldiwgIkNvdWxkIG5vdCBmaW5kIGJ1 bGstaW4gZW5kcG9pbnRcbiIpOwoJCWdvdG8gZXJyb3JFUDsKCX0KCj4gIGRyaXZlcnMvbWVkaWEv dXNiL3N0a3dlYmNhbS9zdGstd2ViY2FtLmMgfCA2ICsrKysrKwoKSSBkaWRuJ3QgYm90aGVyIGxv b2tpbmcgYXQgdGhpcyBkcml2ZXIgdG8gc2VlIGlmIHlvdXIgcGF0Y2ggdGhlcmUgbWFrZXMKbW9y ZSBzZW5zZS4gIFRoYXQgaXMgeW91ciBob21lIHdvcmsgbm93LiAgUGxlYXNlIGV4cGxhaW4gd2h5 IHlvdSBiZWxpZXZlCml0IGlzLiAgQW4gYWN0dWFsIG9vcHMgd291bGQgYmUgZ29vZC4KCjxyYW50 PgpZZXMsIGFuZCBJIGRvIGhhdmUgc29tZSBvYmplY3Rpb25zIHRvIHRoaXMgd2hvbGUgInByb3Rl Y3QgYWdhaW5zdAptYWxpY2lvdXMgZGV2aWNlcyIuICBIb3cgZG8geW91IGludGVuZCB0byBwcm90 ZWN0IGFnYWluc3QgYSBVU0IgZGV2aWNlCmRpc2d1aXNpbmcgaXRzZWxmIGFzIGEga2V5Ym9hcmQg b3IgZXRoZXJuZXQgYWRhcGF0ZXIgb3Igd2hhdGV2ZXI/CkFsbG93aW5nIHBvdGVudGlvbmFsbHkg bWFsaWNpb3VzIGRldmljZXMgaXMgY3JhenkgZW5vdWdoIGZvciBVU0IsIGFuZCBpdApnZXRzIGNv bXBsZXRlbHkgd2Fja28gd2hlbiBwZW9wbGUgc3RhcnQgdGFsa2luZyBhYm91dCBpdCBpbiB0aGUg Y29udGV4dApvZiBmaXJld2lyZSBvciBQQ0llCgpGaXhpbmcgYnVncyBpbiBkcml2ZXJzIGlzIGZp bmUuIEJ1dCBpdCB3b24ndCBtYWtlIGFueSBkaWZmZXJlbmNlIHdydApzZWN1cml0eSBpZiB5b3Ug Y29ubmVjdCBtYWxpY2lvdXMgZGV2aWNlcyB0byB5b3VyIHN5c3RlbS4gIERvbid0IGRvIHRoYXQK aWYgeW91IHdhbnQgYSBzZWN1cmUgc3lzdGVtLgoKQWxsb2NhdGluZyBDVkUgbnVtYmVycyB0byBh cmJpdHJhcnkgZHJpdmVyIGJ1Z3MgaXMganVzdCBhZGRpbmcKbm9pc2UuIFRoaXMgbm9pc2UgbWFr ZXMgaXQgaGFyZGVyIGZvciBzeXNhZG1pbnMgYW5kIG90aGVycyB0byB0byBub3RpY2UKdGhlIHJl YWxseSBpbXBvcnRhbnQgcHJvYmxlbXMuICBObyBvbmUgd2lsbCBjYXJlIGFueW1vcmUgaWYgZXZl cnkga2VybmVsCnJlbGVhc2UgZml4ZXMgdGhvdXNhbmRzIG9mIENWRXMuICBXaGljaCBpcyBwcmV0 dHkgY2xvc2UgdG8gdGhlIHRydXRoIGlmCnlvdSBzdGFydCBhbGxvY2F0aW5nIENWRSBudW1iZXJz IHRvIGFueSBidWcgd2l0aCBhIHNlY3VyaXR5IGltcGFjdC4KPC9yYW50PgoKCgoKQmrDuHJuCg==