Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xRVPj3w4BzDqp9 for ; Tue, 8 Aug 2017 20:04:57 +1000 (AEST) From: Michael Ellerman To: Qiang Zhao , "tglx\@linutronix.de" Cc: "oss\@buserror.net" , "linuxppc-dev\@lists.ozlabs.org" , Xiaobo Xie , "linux-kernel\@vger.kernel.org" Subject: RE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC In-Reply-To: References: <1502075236-24078-1-git-send-email-qiang.zhao@nxp.com> <1502075236-24078-5-git-send-email-qiang.zhao@nxp.com> <87h8xjq2rw.fsf@concordia.ellerman.id.au> Date: Tue, 08 Aug 2017 20:04:56 +1000 Message-ID: <878tiunznb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Qiang Zhao writes: > On Mon 8/7/2017 3:02 PM, Michael Ellerman wrote: > >> -----Original Message----- >> From: Michael Ellerman [mailto:mpe@ellerman.id.au] >> Sent: Monday, August 07, 2017 3:02 PM >> To: Qiang Zhao ; tglx@linutronix.de >> Cc: oss@buserror.net; Qiang Zhao ; linuxppc- >> dev@lists.ozlabs.org; Xiaobo Xie ; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC >> >> Zhao Qiang writes: >> >> > QEIC was supported on PowerPC, and dependent on PPC, Now it is >> > supported on other platforms, so remove PPCisms. >> > >> > Signed-off-by: Zhao Qiang >> > --- >> > arch/powerpc/platforms/83xx/km83xx.c | 1 - >> > arch/powerpc/platforms/83xx/misc.c | 1 - >> > arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 - >> > arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 - >> > arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 - >> > arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 - >> > arch/powerpc/platforms/85xx/corenet_generic.c | 1 - >> > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 - >> > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 1 - >> > arch/powerpc/platforms/85xx/twr_p102x.c | 1 - >> > drivers/irqchip/irq-qeic.c | 188 +++++++++++--------------- >> > include/soc/fsl/qe/qe_ic.h | 132 ------------------ >> > 12 files changed, 80 insertions(+), 250 deletions(-) delete mode >> > 100644 include/soc/fsl/qe/qe_ic.h >> > >> > diff --git a/arch/powerpc/platforms/83xx/km83xx.c >> > b/arch/powerpc/platforms/83xx/km83xx.c >> > index d8642a4..b1cef0a 100644 >> > --- a/arch/powerpc/platforms/83xx/km83xx.c >> > +++ b/arch/powerpc/platforms/83xx/km83xx.c >> > @@ -38,7 +38,6 @@ >> > #include >> > #include >> > #include >> > -#include >> >> You deleted that file in patch 2. So didn't you just break the build for the last two >> commits? > > Sorry, I am not sure what you said. Could you explain? Don't worry about it. I was confused by the fact that we have both: drivers/soc/fsl/qe/qe_ic.h and: include/soc/fsl/qe/qe_ic.h cheers