From: Peter Korsgaard Date: Thu, 09 Mar 2017 23:03:20 +0100 Subject: [Buildroot] [PATCH] kmscube: Move to the new repository In-Reply-To: (Gary Bisson's message of "Thu, 9 Mar 2017 15:53:37 +0100") References: <1488803273-25019-1-git-send-email-festevam@gmail.com> <20170306212225.0819a97b@free-electrons.com> <20170306213121.203079d8@free-electrons.com> Message-ID: <878toeaz13.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Gary" == Gary Bisson writes: Hi, >> I see them defined in two places here: >> >> $ grep -rn DRM_MODE_OBJECT_PLANE output/host/ >> output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/drm/drm_mode.h:336:#define >> DRM_MODE_OBJECT_PLANE 0xeeeeeeee >> output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/libdrm/drm_mode.h:336:#define >> DRM_MODE_OBJECT_PLANE 0xeeeeeeee > So it means your toolchain is using kernel headers >= 4.7. > http://lxr.free-electrons.com/ident?v=4.6;i=DRM_MODE_OBJECT_PLANE > http://lxr.free-electrons.com/ident?v=4.7;i=DRM_MODE_OBJECT_PLANE > Not sure which header version the Linaro toolchain is using but it's > definitely older than 4.7. Based on toolchain/toolchain-external/toolchain-external-linaro-arm/Config.in it is using 4.6. > Thanks for testing it out, good to here it works but I'm still not > sure adding this libdrm/drm_mode.h is the best solution as-is. The question is what happens if kmscube is run on a kernel that doesn't support DRM_MODE_OBJECT_PLANE (E.G. kernel < 4.7)? If it really needs support for this then we should simply make the package depend on >= 4.7 headers, and if not we could add a patch to add the include. -- Bye, Peter Korsgaard