Return-Path: Received: from mail-wj0-f171.google.com ([209.85.210.171]:35045 "EHLO mail-wj0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbcKUVxg (ORCPT ); Mon, 21 Nov 2016 16:53:36 -0500 Received: by mail-wj0-f171.google.com with SMTP id v7so32144279wjy.2 for ; Mon, 21 Nov 2016 13:53:35 -0800 (PST) Received: from morgan.rasmusvillemoes.dk (dhcp-5-186-126-84.cgn.ip.fibianet.dk. [5.186.126.84]) by smtp.gmail.com with ESMTPSA id dj5sm27185835wjb.34.2016.11.21.13.47.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 13:47:15 -0800 (PST) From: Rasmus Villemoes To: linux-fsdevel@vger.kernel.org Subject: locking in fs/signalfd.c Date: Mon, 21 Nov 2016 22:47:14 +0100 Message-ID: <878tscsdy5.fsf@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: What exactly is the purpose of the locking in 298 spin_lock_irq(¤t->sighand->siglock); 299 ctx->sigmask = sigmask; 300 spin_unlock_irq(¤t->sighand->siglock); It doesn't seem to prevent process A from modifying the mask while process B is also doing that (or reading from it in signalfd_{poll,dequeue}). Of course it requires sharing the struct file, but that's certainly possible. Rasmus