Received: from eggs.gnu.org ([2001:4830:134:3::10]:45995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQVkx-0002aD-L9 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:52:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQVks-0001Nt-DT for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:52:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQVks-0001Np-8F for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:52:06 -0500 From: Markus Armbruster References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-11-git-send-email-eblake@redhat.com> <874mds7gsp.fsf@blackfin.pond.sub.org> <56AFE130.7090803@redhat.com> Date: Tue, 02 Feb 2016 08:52:03 +0100 In-Reply-To: <56AFE130.7090803@redhat.com> (Eric Blake's message of "Mon, 1 Feb 2016 15:50:24 -0700") Message-ID: <878u33wnvg.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > On 02/01/2016 05:31 AM, Markus Armbruster wrote: > >>> |+ visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err); >>> | if (err) { >>> | goto out; >>> | } >>> | visit_type_ACPIOSTInfo(v, &info, "info", &err); >>> | if (err) { >>> |- goto out; >>> |+ goto out_obj; >>> | } >>> |- visit_end_struct(v, &err); >>> |+out_obj: >>> |+ visit_end_struct(v, err ? NULL : &err); >> >> Slightly awkward example, because out_obj is pointless in this >> degenerated case. You could pick one with multiple members (thus >> multiple goto out_obj), or do pseudo-code hinting at multiple members. > > DEVICE_DELETED, DEVICE_TRAY_MOVED, MEM_UNPLUG_ERROR, > NET_RX_FILTER_CHANGED, and SPICE_CONNECTED are nice candidates (two > members instead of one). Do you want to take care of redoing any > portion of the commit message? Can do. Unless something comes along that requires a respin.